From: Michal Kubiak <michal.kubiak@intel.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: <intel-wired-lan@lists.osuosl.org>,
<maciej.fijalkowski@intel.com>, <jacob.e.keller@intel.com>,
<larysa.zaremba@intel.com>, <netdev@vger.kernel.org>,
<przemyslaw.kitszel@intel.com>, <pmenzel@molgen.mpg.de>,
<anthony.l.nguyen@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 1/3] ice: remove legacy Rx and construct SKB
Date: Wed, 3 Sep 2025 18:03:09 +0200 [thread overview]
Message-ID: <aLhmvbZ_XXEFzNxW@localhost.localdomain> (raw)
In-Reply-To: <644cab8d-948d-4a32-a5b9-d47b3441eb97@intel.com>
On Wed, Sep 03, 2025 at 05:09:41PM +0200, Alexander Lobakin wrote:
> From: Michal Kubiak <michal.kubiak@intel.com>
> Date: Fri, 8 Aug 2025 17:56:57 +0200
>
> > The commit 53844673d555 ("iavf: kill 'legacy-rx' for good") removed
> > the legacy Rx path in the iavf driver. This change applies the same
> > rationale to the ice driver.
>
> BTW you forgot to remove `ICE_RX_FLAGS_RING_BUILD_SKB` from ice_txrx.h
> and the corresponding inlines (now unused).
>
> Thanks,
> Olek
Yeah, it makes sense. Thanks for reporting that.
I will most likely need to send out v3, as Larysa has identified a potentially
even more serious issue related to XDP_TX.
Therefore, I will remove the flag in v3.
Tony, please hold off on preparing the final pull request for this series
until further notice.
Thanks,
Michal
next prev parent reply other threads:[~2025-09-03 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 15:56 [Intel-wired-lan] [PATCH iwl-next v2 0/3] ice: convert Rx path to Page Pool Michal Kubiak
2025-08-08 15:56 ` [Intel-wired-lan] [PATCH iwl-next v2 1/3] ice: remove legacy Rx and construct SKB Michal Kubiak
2025-08-29 6:17 ` Rinitha, SX
[not found] ` <PH0PR11MB5013108C34B30F5DB4F01D019606A@PH0PR11MB5013.namprd11.prod.outlook.com>
2025-09-02 5:56 ` Singh, PriyaX
2025-09-03 15:09 ` Alexander Lobakin
2025-09-03 16:03 ` Michal Kubiak [this message]
2025-08-08 15:56 ` [Intel-wired-lan] [PATCH iwl-next v2 2/3] ice: drop page splitting and recycling Michal Kubiak
2025-08-29 6:14 ` Rinitha, SX
[not found] ` <PH0PR11MB501328DFC538260A11368B499606A@PH0PR11MB5013.namprd11.prod.outlook.com>
[not found] ` <PH3PPF67C992ECC2AD31E5DB372B564E20A9106A@PH3PPF67C992ECC.namprd11.prod.outlook.com>
[not found] ` <PH3PPF67C992ECC42A31833C78908719A7A9101A@PH3PPF67C992ECC.namprd11.prod.outlook.com>
2025-09-03 7:53 ` Singh, PriyaX
2025-08-08 15:56 ` [Intel-wired-lan] [PATCH iwl-next v2 3/3] ice: switch to Page Pool Michal Kubiak
2025-08-29 6:12 ` Rinitha, SX
[not found] ` <PH0PR11MB50137E847BF9F0BF2FBF127D9606A@PH0PR11MB5013.namprd11.prod.outlook.com>
[not found] ` <PH3PPF67C992ECC2B85C5436B969773E2759106A@PH3PPF67C992ECC.namprd11.prod.outlook.com>
[not found] ` <PH3PPF67C992ECC632806C8E123CB24D1489101A@PH3PPF67C992ECC.namprd11.prod.outlook.com>
2025-09-03 7:57 ` Singh, PriyaX
2025-08-08 23:37 ` [Intel-wired-lan] [PATCH iwl-next v2 0/3] ice: convert Rx path " Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLhmvbZ_XXEFzNxW@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=larysa.zaremba@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).