intel-wired-lan.osuosl.org archive mirror
 help / color / mirror / Atom feed
From: Miroslav Lichvar <mlichvar@redhat.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] igb: Retrieve Tx timestamp directly from interrupt
Date: Tue, 23 Sep 2025 10:01:57 +0200	[thread overview]
Message-ID: <aNJT9a0FA0cM_oBa@localhost> (raw)
In-Reply-To: <87ikhodotj.fsf@jax.kurt.home>

On Fri, Sep 12, 2025 at 11:04:24AM +0200, Kurt Kanzenbach wrote:
> Sebastian found a machine with i350 and gave me access.
> 
> I did run the same test as you mentioned here. But, my numbers are
> completely different. Especially the number of hardware TX timestamps
> are significantly lower overall.
> 
> Without the patch:
> 
> ./ntpperf -i eno8303 -m X -d Y -s Z -I -r 200000 -t 10
> 
> NTP daemon RX timestamps   : 0
> NTP daemon TX timestamps   : 565057
> NTP kernel RX timestamps   : 100208
> NTP kernel TX timestamps   : 281215
> NTP hardware RX timestamps : 882823
> NTP hardware TX timestamps : 136759
> 
> With the patch:
> 
> NTP daemon RX timestamps   : 0
> NTP daemon TX timestamps   : 576561
> NTP kernel RX timestamps   : 99232
> NTP kernel TX timestamps   : 255634
> NTP hardware RX timestamps : 868392
> NTP hardware TX timestamps : 135429

ntpperf sending 200k requests per second for 10 seconds is 2 million,
but the sums of RX or TX timestamps in both your results show it
handled only about half of that. The CPU seems to be too slow for such
rate in either case.

I was testing it with an Intel E3-1220 v6 (4 cores, no hyperthreading)
and I set "-r 200000" to roughly match the maximum rate my machine can
handle before the patch. Can you please try adjusting the rate to
minimize the loss in the test without the patch first?

> What am I doing wrong? Here's my chrony config:

Your config looks good to me. Here is mine, but it is functionally
equivalent wrt this test:

hwtimestamp i350b
clientloglimit 1000000000
local
allow

> 
> |########## i350 NTP performance regression test ###########
> |local stratum 10
> |allow X
> |allow Y
> |allow Z
> |
> |hwtimestamp eno0
> | 
> |clientloglimit 134217728
> |log measurements statistics tracking
> |logdir /var/log/chrony

-- 
Miroslav Lichvar


  parent reply	other threads:[~2025-09-23  8:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15  6:50 [Intel-wired-lan] [PATCH iwl-next] igb: Retrieve Tx timestamp directly from interrupt Kurt Kanzenbach
2025-08-15  7:55 ` Paul Menzel
2025-08-15  8:10   ` Sebastian Andrzej Siewior
2025-08-15  8:17   ` Kurt Kanzenbach
2025-08-15 12:54     ` Paul Menzel
2025-08-15 16:41       ` Sebastian Andrzej Siewior
2025-08-15 13:58     ` Vadim Fedorenko
2025-08-16  9:06       ` Kurt Kanzenbach
2025-08-18 12:24 ` Miroslav Lichvar
2025-08-19  6:09   ` Kurt Kanzenbach
2025-08-19 14:50   ` Kurt Kanzenbach
2025-08-20  6:54     ` Miroslav Lichvar
2025-08-19 23:31   ` Jacob Keller
2025-08-20  7:56     ` Miroslav Lichvar
2025-08-20 20:29       ` Jacob Keller
2025-08-21  7:50         ` Miroslav Lichvar
2025-08-21 11:38         ` Kurt Kanzenbach
2025-08-21 12:59           ` Miroslav Lichvar
2025-08-21 14:08             ` Kurt Kanzenbach
2025-08-21 14:51               ` Miroslav Lichvar
2025-09-12  9:04       ` Kurt Kanzenbach
2025-09-13 21:22         ` Sebastian Andrzej Siewior
2025-09-23  8:25           ` Miroslav Lichvar
2025-09-23  8:01         ` Miroslav Lichvar [this message]
2025-08-19 23:24 ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aNJT9a0FA0cM_oBa@localhost \
    --to=mlichvar@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=richardcochran@gmail.com \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).