From: Your Name <alessandro.d@gmail.com>
To: "Sarkar, Tirthendu" <tirthendu.sarkar@intel.com>
Cc: Jason Xing <kerneljasonxing@gmail.com>,
Alessandro Decina <alessandro.d@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Daniel Borkmann <daniel@iogearbox.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
Stanislav Fomichev <sdf@fomichev.me>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH net v2 1/1] i40e: xsk: advance next_to_clean on status descriptors
Date: Thu, 23 Oct 2025 03:28:26 +1100 [thread overview]
Message-ID: <aPkGKqZjauLHYfka@lima-default> (raw)
In-Reply-To: <SA1SPRMB0026CD60501E3684B5EC67F290F3A@SA1SPRMB0026.namprd11.prod.outlook.com>
On Wed, Oct 22, 2025 at 05:41:06AM +0000, Sarkar, Tirthendu wrote:
> > From: Jason Xing <kerneljasonxing@gmail.com>
>
> I believe the issue is not that status_descriptor is getting into
> multi-buffer packet but not updating next_to_clean results in
> I40E_DESC_UNUSED() to return incorrect values.
I don't think this is true? next_to_clean can be < next_to_process by
design, see
if (next_to_process != next_to_clean)
first = *i40e_rx_bi(rx_ring, next_to_clean);
at the start of i40e_clean_rx_irq_zc. This condition is normal and means
when we exited the function - for example because we ran out of budget -
we were in the middle of a multi-buffer packet and now we must continue.
If I understand the code, I think that in that case we just set
entries_to_alloc to a lower number and return fewer buffers to the
hardware.
> A similar issue was
> reported and fixed on the non-ZC path:
> https://lore.kernel.org/netdev/20231004083454.20143-1-tirthendu.sarkar@intel.com/
This is indeed exactly the same issue, but I'm not yet sold on the
diagnosis :D
Ciao,
Alessandro
next prev parent reply other threads:[~2025-10-22 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 17:31 [Intel-wired-lan] [PATCH net v2 0/1] i40e: xsk: advance next_to_clean on status descriptors Alessandro Decina
2025-10-21 17:32 ` [Intel-wired-lan] [PATCH net v2 1/1] " Alessandro Decina
2025-10-22 3:11 ` Jason Xing
2025-10-22 5:41 ` Sarkar, Tirthendu
2025-10-22 7:28 ` Jason Xing
2025-10-22 16:28 ` Your Name [this message]
2025-10-23 6:11 ` Sarkar, Tirthendu
2025-10-22 16:17 ` Alessandro Decina
2025-10-22 6:41 ` Loktionov, Aleksandr
2025-10-22 17:17 ` Maciej Fijalkowski
2025-10-22 17:39 ` Your Name
2025-11-03 15:14 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPkGKqZjauLHYfka@lima-default \
--to=alessandro.d@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@fomichev.me \
--cc=tirthendu.sarkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).