From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E024D11183 for ; Thu, 27 Nov 2025 11:44:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5008F4114B; Thu, 27 Nov 2025 11:44:46 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id jzawcXG1wc17; Thu, 27 Nov 2025 11:44:45 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 85A6940F53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1764243885; bh=x7qg6Jem7VzlJyrA3FdqmkHriCBJzkr3Z7KK5sYAA1g=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=C6or44+IXjcQGpUpKHnCvHDfHfbMxVFJWjfqQeFCuDQgd9t1VK/Ji9OYAev/9PU6R SVDapMVVFDInSMvJgHaPr+av4IZ/XuqPFpKhqYl0X/Q6Odk9WIfcTtFw8lHFWNM+RM MC2QrymHw4t3OiWVTzMzGOP1oZ5aQ9N2oDEeuYlzeFislLyoTsGTfdvD2pQU5MO22g MlorUvAFvt6OY3F0l5u8zMonntP2nMGFi1ISuwU3vJSLpUyN1xvLP64TJL/qg292EJ 5QdP4JQqf2mEW2GB++o9JJNoSm6r3soVBdJ6TVBACovxTJWt0AzNkv9e3OH83TEEtG WBclDG6+6gWJw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 85A6940F53; Thu, 27 Nov 2025 11:44:45 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id F0A75708 for ; Thu, 27 Nov 2025 11:44:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E2DA04028F for ; Thu, 27 Nov 2025 11:44:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AwzCGDdnuRiu for ; Thu, 27 Nov 2025 11:44:43 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org E72BB4019A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E72BB4019A Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp2.osuosl.org (Postfix) with ESMTPS id E72BB4019A for ; Thu, 27 Nov 2025 11:44:42 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 4CC7D43EF5; Thu, 27 Nov 2025 11:44:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D691CC4CEF8; Thu, 27 Nov 2025 11:44:40 +0000 (UTC) Date: Thu, 27 Nov 2025 11:44:38 +0000 From: Simon Horman To: Sreedevi Joshi Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Aleksandr Loktionov , Sridhar Samudrala , Emil Tantilov Message-ID: References: <20251124184750.3625097-1-sreedevi.joshi@intel.com> <20251124184750.3625097-3-sreedevi.joshi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251124184750.3625097-3-sreedevi.joshi@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764243882; bh=8B3PWkcneEp8j4f+naDD6Gjqui7eqqG/efW5UvE2XH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QCLe2OIuIK9wjKClO/r9uyaeQ15V7N/qN6sDhYFWeDI2Z4Zp4gK4FPsONwLX2rwcH tfzYe44SX9LSCUgFA2ov2A6XZkPitg2cUqReAIFJTKI4A0miQkv0MvTki1qmW589xU VI2y2WMVHhOdmyEvY/IiTPxKxJRQvVaxWP6g417Yxuila1C5k6D4KfdGBGm6mcLU5C WuIG38jrSYsix3D1s3TXIcupJ1xXainImFuTwRLcD/xXwKUG7vTL24qOIHF58NWwM3 MqtfMovzdV99mCiWKOg1zJIlWcLzS51EHBRLzV+Kyb85OQWObyeG+kZ7PoftguOMHx 9Zb/34wrUnRRQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QCLe2OIu Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 2/3] idpf: Fix RSS LUT configuration on down interfaces X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Nov 24, 2025 at 12:47:49PM -0600, Sreedevi Joshi wrote: > RSS LUT provisioning and queries on a down interface currently return > silently without effect. Users should be able to configure RSS settings > even when the interface is down. > > Fix by maintaining RSS configuration changes in the driver's soft copy and > deferring HW programming until the interface comes up. > > Fixes: 02cbfba1add5 ("idpf: add ethtool callbacks") > Signed-off-by: Sreedevi Joshi > Reviewed-by: Aleksandr Loktionov > Reviewed-by: Sridhar Samudrala > Reviewed-by: Emil Tantilov > --- > drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c ... > @@ -424,7 +429,7 @@ static int idpf_get_rxfh(struct net_device *netdev, > > if (rxfh->indir) { > for (i = 0; i < rss_data->rss_lut_size; i++) > - rxfh->indir[i] = rss_data->rss_lut[i]; > + rxfh->indir[i] = rxhash_ena ? rss_data->rss_lut[i] : 0; Hi, I feel that I am missing something here. But I would have expected rxfh->indir to be populated by rss_data->rss_lut regardless of the port is up or down. IOW, I'm unclear on why 0 is reported for the indirection table if the interface is down. > } > > unlock_mutex: ...