From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A34E5EEA84B for ; Thu, 12 Feb 2026 20:53:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 45B6660699; Thu, 12 Feb 2026 20:53:18 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id X5T6AdjssWdi; Thu, 12 Feb 2026 20:53:16 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 247BA60690 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1770929596; bh=kmi2KpdNutp/lnxWHeXmO0XUXwcVgkExZIzgwKZ+NYE=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=t182PB8/8yrsmYfGHVzzwaSwtwA+BcAdSesTCus2YaPDzDuvOiwQcHrSif3wygtsu w+rZRcnw6IAPdZc/y94e7weNT3F6eJUCool4vJo2yS/6CpVBrjz4iAr18J7CgS8S0S Fy6Vs7Ux80JA/HX8Xo0d7Bw4ENu8PSLb5pWPj0H0Xi7bEum7tNYr2RBHXOebNx0/bD 022pVn9Ng+So0a6IJlhmEZrk4mJRr3bKnUSO/cBn2gG/7dOZrAQsw8v+o2NqgHjq1O 16aif384ELUkJD4d9gsKEwlcikFAoh7bLYfxx6LTFN6WlyFUnIW5mKFUvpcws8I6WU Q/UcfRkbvcJ3g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 247BA60690; Thu, 12 Feb 2026 20:53:16 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id CEA0C23D for ; Thu, 12 Feb 2026 20:53:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B214640A45 for ; Thu, 12 Feb 2026 20:53:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PRsapZdRpJSr for ; Thu, 12 Feb 2026 20:53:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 0EF8C40370 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0EF8C40370 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0EF8C40370 for ; Thu, 12 Feb 2026 20:53:12 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7A47F60018; Thu, 12 Feb 2026 20:53:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38BEDC4CEF7; Thu, 12 Feb 2026 20:53:10 +0000 (UTC) Date: Thu, 12 Feb 2026 20:53:08 +0000 From: Simon Horman To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Aleksandr Loktionov Message-ID: References: <20260211091008.236185-1-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260211091008.236185-1-michal.swiatkowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770929591; bh=iIYldWO1yWWolN4bbBuyPnJV93TUrrkg80C+Xk+0TG8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ML+Q0QqQExCIEzt7Fb+XfoWE7sXr7uEQ2RqdkokUX7il/S+CSCfdRB3k/sQMUrHH1 m+vRPnrvgsty8IO9MCUPNz/DQ902Gwxty1eYKDmGHa9WpoZXNjoVexSfh52tOlOBZh OubEyfYokGPMkr+kepYNT2l8stISbZJVW0TWhruWRAWivblb2GSqDCcTEJGZuqjtBN kT0EG0lELKwdGPbk2czHkf009PosoKUKLMTAwhUcK2b3zXApEkTKxCgwIad/np1fCN Pk6Xb5wHzl0G3cKH0j5iCFeb4otMKouIMKzBHqo43xa2QDTGLggZEdVGF3co5QoXN/ 3Jhd990IAJcFg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ML+Q0QqQ Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] libie: prevent memleak in fwlog code X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Feb 11, 2026 at 10:10:08AM +0100, Michal Swiatkowski wrote: > All cmd_buf buffers are allocated and need to be freed after usage. > Add an error unwinding path that properly frees these buffers. > > The memory leak happens whenever fwlog configuration is changed. For > example: > > $echo 256K > /sys/kernel/debug/ixgbe/0000\:32\:00.0/fwlog/log_size > > Fixes: 96a9a9341cda ("ice: configure FW logging") > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman