From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7410FEEA84B for ; Thu, 12 Feb 2026 21:00:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2E16581322; Thu, 12 Feb 2026 21:00:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8ecVQJRw5AT3; Thu, 12 Feb 2026 21:00:23 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9CCC281297 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1770930023; bh=TtBwbHyf9ZO3yWNFD0oSknUP+3qIFIVh1BBfxKjHq7E=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nmN9OIllvwwY9uIQX0RBzj9GDdGk/zFmiXvhEIm7MSPSc4Pth8mHa2yS6XTgfC02l r10hZc2yepBiEpAXXyc0te3KmSzp1mXMosu79erJ0p3rHRoWQBLE/EHG0P+27lb9dY Wn4lTWGI14stvPgUAydL2Qlpj/h2eg3wZ/xLl5Du47Yoi6eDUcZNBydCHpR6qU8mz1 YDtF9NK7I9aLry927W+WoNrBaG7Puaw70H5RAtVKkqQuATKeV2PrYCRc96Lqng4qN1 dySInw4fDCf27rF8hllTpyvxjowSdrFX8iRZRVaN5X5GzcBlF3HKsjbUj3+nE1B3u+ pNzi1sOGW4d5A== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 9CCC281297; Thu, 12 Feb 2026 21:00:23 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 917F31D6 for ; Thu, 12 Feb 2026 21:00:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7F75B60799 for ; Thu, 12 Feb 2026 21:00:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SEyYtQ2z3Q2p for ; Thu, 12 Feb 2026 21:00:21 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org D9ED660783 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D9ED660783 Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp3.osuosl.org (Postfix) with ESMTPS id D9ED660783 for ; Thu, 12 Feb 2026 21:00:20 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 304E141B0C; Thu, 12 Feb 2026 21:00:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13828C19421; Thu, 12 Feb 2026 21:00:18 +0000 (UTC) Date: Thu, 12 Feb 2026 21:00:17 +0000 From: Simon Horman To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Aleksandr Loktionov Message-ID: References: <20260211091140.236389-1-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260211091140.236389-1-michal.swiatkowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770930020; bh=aaE1KRdXIdYiNBsEC1LLonMgcfm5pyUvYhv0fyJFMME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PyyOebaXvwQVs+VyVwmUXJxAv9GCHN9hZgvK2FMm4UiHrOy90vyIQqgIGVbnVKsTj 83FAWSDzABZLqa3v0ZLZIny9wOBvlsqV3nzACgStkKM28Jbud0UTJ3sPEqIAZ7QaKp zr9pfYARSb8s8mMaNkjAicxEs25zaVZpv9tCjo4wuss1Y2+ibntXNlWj126hfUmE9a wAPRBVU08PaGIKYHJF3q2+czSFuoHUnlLq/BOXJghrayw8oogGqDKkNO6vzW2eCCbi eQbxP7eFBWjA2nZosnznLt9krzMVNlyWXVD7DmRYf+wtRL32n1EplWHeGnY+Rtakrs vHx5cKaMAt/vw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=PyyOebaX Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] libie: don't unroll if fwlog isn't supported X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Feb 11, 2026 at 10:11:40AM +0100, Michal Swiatkowski wrote: > The libie_fwlog_deinit() function can be called during driver unload > even when firmware logging was never properly initialized. This led to call > trace: > > [ 148.576156] Oops: Oops: 0000 [#1] SMP NOPTI > [ 148.576167] CPU: 80 UID: 0 PID: 12843 Comm: rmmod Kdump: loaded Not tainted 6.17.0-rc7next-queue-3oct-01915-g06d79d51cf51 #1 PREEMPT(full) > [ 148.576177] Hardware name: HPE ProLiant DL385 Gen10 Plus/ProLiant DL385 Gen10 Plus, BIOS A42 07/18/2020 > [ 148.576182] RIP: 0010:__dev_printk+0x16/0x70 > [ 148.576196] Code: 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 41 55 41 54 49 89 d4 55 48 89 fd 53 48 85 f6 74 3c <4c> 8b 6e 50 48 89 f3 4d 85 ed 75 03 4c 8b 2e 48 89 df e8 f3 27 98 > [ 148.576204] RSP: 0018:ffffd2fd7ea17a48 EFLAGS: 00010202 > [ 148.576211] RAX: ffffd2fd7ea17aa0 RBX: ffff8eb288ae2000 RCX: 0000000000000000 > [ 148.576217] RDX: ffffd2fd7ea17a70 RSI: 00000000000000c8 RDI: ffffffffb68d3d88 > [ 148.576222] RBP: ffffffffb68d3d88 R08: 0000000000000000 R09: 0000000000000000 > [ 148.576227] R10: 00000000000000c8 R11: ffff8eb2b1a49400 R12: ffffd2fd7ea17a70 > [ 148.576231] R13: ffff8eb3141fb000 R14: ffffffffc1215b48 R15: ffffffffc1215bd8 > [ 148.576236] FS: 00007f5666ba6740(0000) GS:ffff8eb2472b9000(0000) knlGS:0000000000000000 > [ 148.576242] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 148.576247] CR2: 0000000000000118 CR3: 000000011ad17000 CR4: 0000000000350ef0 > [ 148.576252] Call Trace: > [ 148.576258] > [ 148.576269] _dev_warn+0x7c/0x96 > [ 148.576290] libie_fwlog_deinit+0x112/0x117 [libie_fwlog] > [ 148.576303] ixgbe_remove+0x63/0x290 [ixgbe] > [ 148.576342] pci_device_remove+0x42/0xb0 > [ 148.576354] device_release_driver_internal+0x19c/0x200 > [ 148.576365] driver_detach+0x48/0x90 > [ 148.576372] bus_remove_driver+0x6d/0xf0 > [ 148.576383] pci_unregister_driver+0x2e/0xb0 > [ 148.576393] ixgbe_exit_module+0x1c/0xd50 [ixgbe] > [ 148.576430] __do_sys_delete_module.isra.0+0x1bc/0x2e0 > [ 148.576446] do_syscall_64+0x7f/0x980 > > It can be reproduced by trying to unload ixgbe driver in recovery mode. > > Fix that by checking if fwlog is supported before doing unroll. > > Fixes: 641585bc978e ("ixgbe: fwlog support for e610") > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman