From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28C9BE9538D for ; Wed, 4 Feb 2026 11:58:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D33C360A80; Wed, 4 Feb 2026 11:58:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AIMmNmEFA8VD; Wed, 4 Feb 2026 11:58:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0AAF160A41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1770206324; bh=WkdJ9/NPTtPjPWFP5fSTau69QakQJcfrJGJQoXectg8=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gJUSWg0zm4alUS0sngmKntv9QWIijMdHSwy38wssz3HMzWHFC3LE8DzF5O+Ac24FK pz5oLMCYSlr4gxXdB7f9/FxrAjY+UBlfMk03rxf5f7VWl1TTyxVmHswXW8YOyrjGy4 no/EoWrffvL9QK+G6rB9zdL3iK1Byg1OEk4LsMfe3VQVDShbMcLpbsSkoQL6yiuoRr Q21o11H9bNk85IvjANDqvBrCTHCncUm+0Hk6nKl8OasEMRFPIlegqdGHispfAtFHEJ ZbRjuDhZUHhaguW+REIx1oHZgWFp+urgZUkyoE0xse+YVjinHRk9+fHwotIhMNyza9 eOBErmPCuh04Q== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 0AAF160A41; Wed, 4 Feb 2026 11:58:44 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id EBE90173 for ; Wed, 4 Feb 2026 11:58:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D87C3832BF for ; Wed, 4 Feb 2026 11:58:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id mOuTU573UBzU for ; Wed, 4 Feb 2026 11:58:42 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 3B6DC81E1C DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3B6DC81E1C Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp1.osuosl.org (Postfix) with ESMTPS id 3B6DC81E1C for ; Wed, 4 Feb 2026 11:58:41 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5D585444CE; Wed, 4 Feb 2026 11:58:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FA93C16AAE; Wed, 4 Feb 2026 11:58:38 +0000 (UTC) Date: Wed, 4 Feb 2026 11:58:36 +0000 From: Simon Horman To: Aaron Ma Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: References: <20260129040026.832452-1-aaron.ma@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260129040026.832452-1-aaron.ma@canonical.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770206321; bh=aBgYq5sKLNarh8sJoMQ3wtdCMcUApTBI0ornbC2y7YY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W8Kz6ly2u6h4bavNw72G6Hf58FESgDqolQMQYYpIEDvhwpPiOyUfQt2ZM+xurObbZ tH9zLXq/95DNhEL2zAUodYlHbc76EqX6Q5R646qCwWIj56R20+OkO/UAUxKAE1qOT4 /nMBsXfzAwDlqljUezJwdqUPkvdu+LmGMhS9RzRTzh456wUqgte5a7aNCcUOHLLglX YmboBUItpr9H2e0uN4vdJ+apjN1Ey0JKcqtTGRrz/aaSW68/BuqRRT6K8GCR6hVxs9 RhjT6V6mhOiLtlvA5VNrqLkQXQPfSP6t4BCp+fYu01RZtPkITMCnxCai9kWePV8hmh zr2atUFgAMKjQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=W8Kz6ly2 Subject: Re: [Intel-wired-lan] [PATCH v4] ice: recap the VSI and QoS info after rebuild X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jan 29, 2026 at 12:00:26PM +0800, Aaron Ma wrote: > Fix IRDMA hardware initialization timeout (-110) after resume by > separating VSI-dependent configuration from RDMA resource allocation, > ensuring VSI is rebuilt before IRDMA accesses it. > > After resume from suspend, IRDMA hardware initialization fails: > ice: IRDMA hardware initialization FAILED init_state=4 status=-110 > > Separate RDMA initialization into two phases: > 1. ice_init_rdma() - Allocate resources only (no VSI/QoS access, no plug) > 2. ice_rdma_finalize_setup() - Assign VSI/QoS info and plug device > > This allows: > - ice_init_rdma() to stay in ice_resume() (mirrors ice_deinit_rdma() > in ice_suspend()) > - VSI assignment deferred until after ice_vsi_rebuild() completes > - QoS info updated after ice_dcb_rebuild() completes > - Device plugged only when control queues, VSI, and DCB are all ready > > Fixes: bc69ad74867db ("ice: avoid IRQ collision to fix init failure on ACPI S3 resume") > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Aaron Ma Reviewed-by: Simon Horman