From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4DE7F4BB68 for ; Tue, 24 Feb 2026 17:55:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 813BD60DD4; Tue, 24 Feb 2026 17:55:03 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7D_5SJk9gNS9; Tue, 24 Feb 2026 17:55:02 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B279160DFE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1771955702; bh=PzIMItAzXY421iLOa91adHSebAgq8xRhhf8cLoLTUJw=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=T1XWGldHbrRsd/aeuS0PnGWeprJ7SPasUIooa73lxo2evPHoA3MYYZMNK0p8VrbQI GpXAjyZaSekHH4volLi6Auiegrv5Xt3jyuxJe3zpFg+H16a5kSdIv1hLiFoaO2Eus7 GANqXbaH/VMqFUzugPpbAczchNGy3+6bZVaLwAK2zPmVFVN4kNlXONhy9ORJ0Nc7vU J+5eftyYceJI9DGEoLJfDScjgslin57OOQ38Ey2sNwbqvzG/8cL6Bt82iNH3tQnlEd bJ7TbW45oOq0I75JTEI6DZQ9FkiGxUeQdIdTobQN97b188pR4YXj+zgVtMy478pc6b rAd041hh4MxeQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id B279160DFE; Tue, 24 Feb 2026 17:55:02 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 50BF2249 for ; Tue, 24 Feb 2026 17:55:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 422C240B4B for ; Tue, 24 Feb 2026 17:55:01 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id VVfO5RCawlBv for ; Tue, 24 Feb 2026 17:55:00 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9F46940B48 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9F46940B48 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9F46940B48 for ; Tue, 24 Feb 2026 17:55:00 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 19A034450E; Tue, 24 Feb 2026 17:55:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53B90C116D0; Tue, 24 Feb 2026 17:54:56 +0000 (UTC) Date: Tue, 24 Feb 2026 17:54:54 +0000 From: Simon Horman To: Larysa Zaremba Cc: Tony Nguyen , intel-wired-lan@lists.osuosl.org, Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Aleksandr Loktionov , Natalia Wochtman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Message-ID: References: <20260223095222.3205363-1-larysa.zaremba@intel.com> <20260223095222.3205363-7-larysa.zaremba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223095222.3205363-7-larysa.zaremba@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771955700; bh=8VrcD46dycy0DmTlHRXutqJ3iyRT/XCLxmuZYonmw+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cJObRucUqbih7KkJPWJZwIp6ChpzPJMBFVAfVkOFpiFv7k73CVjDP5LQImwP1kQze ZJvYCfiaUywKjhFQGmIjBKstSyBKa6IzWOtX8D3miyxSrQjBOqiZpGuSUk7LcBJxwg QDfKE5mtlAc1XNk56axpFGOdKWwaVT6+wTI9YXFeqyBHBMpHL8OXzYxEGINmUFC4S0 gFBx31dknflFgj/OxegwmafHV6iZMOwROmWt/YkAr+Z2Lcrt3YG7zPaln+naa/+5XI 25UcZGIzHSz2Cu6BAfrHLNm+ZSw5wLZ1yiLgZaNKMWYFB7a5y8UZTgBVaIGVjM7Bv8 mrf/VP6SCXvOQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cJObRucU Subject: Re: [Intel-wired-lan] [PATCH iwl-next 06/10] ixgbevf: XDP_TX in multi-buffer through libeth X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Feb 23, 2026 at 10:52:13AM +0100, Larysa Zaremba wrote: ... > diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h > index eada53c57fcf..67d10e6e9910 100644 > --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h > +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h > @@ -82,20 +82,22 @@ struct ixgbevf_ring { > struct net_device *netdev; > struct bpf_prog *xdp_prog; ... > diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c ... > @@ -784,11 +865,19 @@ static int ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector, > unsigned int total_rx_bytes = 0, total_rx_packets = 0; > struct ixgbevf_adapter *adapter = q_vector->adapter; > u16 cleaned_count = ixgbevf_desc_unused(rx_ring); > + LIBETH_XDP_ONSTACK_BULK(xdp_tx_bulk); > LIBETH_XDP_ONSTACK_BUFF(xdp); > + u32 cached_ntu; > bool xdp_xmit = false; > int xdp_res = 0; > > libeth_xdp_init_buff(xdp, &rx_ring->xdp_stash, &rx_ring->xdp_rxq); > + libeth_xdp_tx_init_bulk(&xdp_tx_bulk, rx_ring->xdp_prog, > + adapter->netdev, adapter->xdp_ring, > + adapter->num_xdp_queues); Hi Larysa, Sparse flags that libeth_xdp_tx_init_bulk() expects xdp_prog to be managed using __rcu, but that is not the case for rx_ring->xdp_prog. .../ixgbevf_main.c:875:9: error: incompatible types in comparison expression (different address spaces): .../ixgbevf_main.c:875:9: struct bpf_prog [noderef] __rcu * .../ixgbevf_main.c:875:9: struct bpf_prog * ...