From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E823EFD23D for ; Wed, 25 Feb 2026 09:59:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 162A284693; Wed, 25 Feb 2026 09:59:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id jaRrLrbCI3yU; Wed, 25 Feb 2026 09:59:49 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 15B578468A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1772013589; bh=S5535crDGvST+ib8rcSTBkGop+thABgOhKT/8fM9fCU=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wUGldG6GUwcrmB1Nao9d+Db5ILDqlTT8A6ghevCmvA0UDwofCGKZ8MrVSQAdi050s cC5ER2lgyi99j7C9OLF0C5nh3+AaGxRnnOiHzjr8Z0oOuJfUrA0k9m/h1bzwDk3Hlu bZp1Ff80cSVZK7C9ruobiqRoY4e7qdVA4/sziV4m5P7m2bpGTlunkod5lB6iJv+ZDq 5E2nipztMYz8z7a4fKZF6wbMWeJ+61wnDPoYlrldlsSRL/lIF53KJs8AZRZRau94YD M/uF3B/CKA+36sjlF32GbXSMzzcFGNXhBbt05Q+ihHuPNh+vuKKoANPCIL8PXeWMTb Lrr06mLWS2eSw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 15B578468A; Wed, 25 Feb 2026 09:59:49 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id D2BD5204 for ; Wed, 25 Feb 2026 09:59:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B82C18468F for ; Wed, 25 Feb 2026 09:59:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id pnI0Awz0eQQn for ; Wed, 25 Feb 2026 09:59:47 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 1CA1B8468A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1CA1B8468A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1CA1B8468A for ; Wed, 25 Feb 2026 09:59:46 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7A1F860053; Wed, 25 Feb 2026 09:59:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BC0EC116D0; Wed, 25 Feb 2026 09:59:43 +0000 (UTC) Date: Wed, 25 Feb 2026 09:59:41 +0000 From: Simon Horman To: Przemyslaw Korba Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com Message-ID: References: <20260223143214.241797-1-przemyslaw.korba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260223143214.241797-1-przemyslaw.korba@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772013585; bh=unrCpWR0ZUEpdxq3xVrxxq2dTQ1Gxls1sXOcFsbziJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=neBGT/qtGwdrHvi/EBGGCJvW4Q2pyDnXSE0bhqWmDauu/4pln2gpvcU7LizVCTXcG CEro1Mfixxi83KUDz1kyprGdPaNMYsJKBmYm8oUc2t8WsvCO7s3OYRZXm7s2W08Ehz otJpgz4dZzQuHLJ1hmdnb0vryhJQDapsYc59UVTTFekhRFQqNYnqlqFGgYuN5oKrdp WZsiqBURIvny5zJ/wZ2t77+7sxDZa6XLYhAOkz4/pS86I5/GRhPIuagFgBGmc2sIQw ZsJAiQEeNTAHNzT3A/gXY30OZfYlPJtSylQB+FnKxvTMCUqxXsejq/rLCEK/dZ+nu3 ZPthXlsflwe5Q== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=neBGT/qt Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: dpll: Fix compilation warning X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Feb 23, 2026 at 03:31:55PM +0100, Przemyslaw Korba wrote: > ice_dpll.c: In function ‘ice_dpll_init’: > ice_dpll.c:3588:59: error: ‘%u’ directive output may be truncated > writing between 1 and 10 bytes into a region of size 4 > [-Werror=format-truncation=] snprintf(pin_name, sizeof(pin_name), > "rclk%u", i); > > Fixes: ad1df4f2d591 ("ice: dpll: Support E825-C SyncE and dynamic pin discovery") > Signed-off-by: Przemyslaw Korba Hi Przemyslaw, I agree that it is good to address this problem. But is it a bug? It seems to me that of the 8 bytes of pin_name, three are available for %u. So values up to 999 can be safely formatted. And I suspect that pf->dplls.rclk.num_parents is always significantly smaller than that. If so, I'd suggest this is iwl-next material. And should not have a Fixes tag. But you could cite the commit that introduced the problem something like this (the part starting with 'commit' is the syntax for citing commits): Introduced by commit ad1df4f2d591 ("ice: dpll: Support E825-C SyncE and dynamic pin discovery") ...