From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 471CDFD88C4 for ; Tue, 10 Mar 2026 22:11:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F11F860E18; Tue, 10 Mar 2026 22:11:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id X62Gq73sZadg; Tue, 10 Mar 2026 22:11:13 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 56AD96082A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1773180673; bh=bjFZ9oZWWc3RZ4UdO5rq+AZbr7uPDX73K58gh1+yuH0=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vlf6ZxDUFCFKgh1VvZUltAdiSiDVpEs560za+cdjBGWBkR90iRvz8vTYY5tgmsEyp mjz558mlK2otK6/GVhc88b0bpWRIFZRt7DnUC23dY3qSuSU+6PoVhCnAn4oLZYvc+i sV+buUHTq8i/B2TlBRmD3ZeI3F2BAjCSWULFDx1ytmdGEl4piGMmX1ROLFm8INIHYa 8rFlzKBu4lcSHL3acWSaLTT9k9IXUzb7Gq67fJogWxSob+3KRX+Nusxf0+h5Zm8TrQ UnjYQa3G3xjC3M/mA6DCnPekdvONCRH1fMgNCiWm6s7G/YPiUcr6Q6Rt4+KOLYnKjs E0NRQekN7E0Bg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 56AD96082A; Tue, 10 Mar 2026 22:11:13 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id E1BA3B8 for ; Tue, 10 Mar 2026 18:40:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D385860D8D for ; Tue, 10 Mar 2026 18:40:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zLuHGk8SFI2Z for ; Tue, 10 Mar 2026 18:40:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::52a; helo=mail-pg1-x52a.google.com; envelope-from=visitorckw@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 3BC5A60D87 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3BC5A60D87 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3BC5A60D87 for ; Tue, 10 Mar 2026 18:40:50 +0000 (UTC) Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-c6dd5b01e14so4653197a12.0 for ; Tue, 10 Mar 2026 11:40:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773168050; x=1773772850; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bjFZ9oZWWc3RZ4UdO5rq+AZbr7uPDX73K58gh1+yuH0=; b=bUdnaFQ+iW0ljCQ9Gs97TOlttASiJIjrCoUoZVgFeVHMitQNoG4T+XNSAQ78mSDIVA ja4LNbFNUQ+EXcGLHxbHZUW+K9RDodio0786m46IFI3prCavDv9BZ2QKuB9ATRNsHpo7 9tn8rKW+2YUW89MGK3VEsI4sro4oae2XG3AqlGcWeV0a4E7hnaDbfUxHbV0gh7tgXM1n XUcSiW1MI0XKqNJVkseiPZ1XaJ9LDsUsC5Y5HEaqIZdGwcrezFV8B6f5N5PBb0LXAquz oef78h/NBCr5O+9yHzJl5HaDs6cEAUGtibDchFgMe5JfYDrPiodcUjC/aBBueawc3ncx gwKw== X-Forwarded-Encrypted: i=1; AJvYcCXI7pc8HQxVbEW1x8foWIdJImxGBzUQ8oywuMKOqIMLVkoSCZ4UtfTYDfb/JqK5BWaGlowMIkdnu83TxO0hswg=@lists.osuosl.org X-Gm-Message-State: AOJu0YwZxGObrQwdNkY+T6CqkBC2AGawoJRcrwZXiD8nCZKwcFUkT+5l U0gq3doHC+vOxBiO+BWUk4Goohr12gXaroyAmiv3ygkY2kzUdjyZLKz3 X-Gm-Gg: ATEYQzxg/cBTq2bLCzyWJ09SH/P5z3sMvKeEmSfjXMKwuTPlLIL20mQ6OVqLHMp9edJ XaKACT8os0ehqACAhnqsWsCVqVzRCSgA7b78OAd6IWw7VjaqRxoqtlQw5YEU0gyNJA987H8iDFp QkDxbBdvwJSyk98ouRMCPWGN8QTUoqDx55Wj2UJQG9DXSPYHxrFqP/BY2aFeBMezDqI83LdUS5b Ssy+H20tnxn1/CpG11EPyLEWPVdh6mbAL9AyIg2vPw9MSiIb/sqQComZwa2gvG7EWYJfgY0sjW9 APAxkbkdp6zF3+Dts/UaNg7RLMq9JLOQUe7Nc2xmIdQ/Jb/BNcI5UFNRPCM3uMvkL2KJjTpiuS5 LTwJJXTomMj1ZFJG6W+lGunzdow0kHxw5aFdl6B8ojqojZ0BL4MfyNGbzQ/pIBqtkiZkzt05c6T ORRoXMToD+ZOv9IQ2rNCyTMttgGitnKp2LY9nuTRtM/Moj+Q== X-Received: by 2002:a17:903:28c8:b0:2ae:5671:7071 with SMTP id d9443c01a7336-2ae8252cf0fmr96662285ad.43.1773168050081; Tue, 10 Mar 2026 11:40:50 -0700 (PDT) Received: from google.com ([2402:7500:a44:85b:2953:97d3:b283:95c3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e58592sm220535625ad.14.2026.03.10.11.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 11:40:49 -0700 (PDT) Date: Wed, 11 Mar 2026 02:40:36 +0800 From: Kuan-Wei Chiu To: Philipp Hahn Cc: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev Message-ID: References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> X-Mailman-Approved-At: Tue, 10 Mar 2026 22:11:12 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773168050; x=1773772850; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bjFZ9oZWWc3RZ4UdO5rq+AZbr7uPDX73K58gh1+yuH0=; b=ZYqDjrhflXFUbHTO6zdGe8ox3Uea2ktlDmfDODpS+vWoGkYC77mjBrDwARRuHsnYjN F90uxErDbDros7ne9Ay11e2Motjov9izW2dgxsMP11PwR1bxeKgHVF3NzvlKgb28DGz2 6u8V5rqB9il73LKEZnJbohYV1zrErL+LqYupbu4mfK6dVCyejjpRONHgfo4GT9hajcOa Rf0XX5D/Bwksm4buorvQ3w4yujyf+f79NlUejKVdhv2ISH5oJRD5K8eoOVpPE9or2kF+ kjq/DQTaypiao25iWWG1UsHaNpzTEez7Sf1wRhOMGShhb3NCAehTBjS3uUk0gYfWYGqc hXLA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ZYqDjrhf Subject: Re: [Intel-wired-lan] [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hi Philipp, On Tue, Mar 10, 2026 at 12:48:26PM +0100, Philipp Hahn wrote: > While doing some static code analysis I stumbled over a common pattern, > where IS_ERR() is combined with a NULL check. For that there is > IS_ERR_OR_NULL(). > > I've written a Coccinelle patch to find and patch those instances. > The patches follow grouped by subsystem. > > Patches 55-58 may be dropped as they have a (minor?) semantic change: > They use WARN_ON() or WARN_ON_ONCE(), but only in the IS_ERR() path, not > for the NULL check. Iff it is okay to print the warning also for NULL, > then the patches can be applied. > > While generating the patch set `checkpatch` complained about mixing > [un]likely() with IS_ERR_OR_NULL(), which already uses likely() > internally. I found and fixed several locations, where that combination > has been used. Thanks for the patchset. However, I think we need a explanation for why switching to IS_ERR_OR_NULL() is an improvement over the existing code. IMHO, the necessity of IS_ERR_OR_NULL() often highlights a confusing or flawed API design. It usually implies that the caller is unsure whether a failure results in an error pointer or a NULL pointer. Rather than doing a treewide conversion of this pattern, I believe it would be much more meaningful to review these instances case-by-case and fix the underlying APIs or caller logic instead. Additionally, a treewide refactoring like this has the practical drawback of creating unnecessary merge conflicts when backporting to stable trees. Regards, Kuan-Wei