From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dvora Fuxbrumer Date: Tue, 2 Mar 2021 10:20:38 +0200 Subject: [Intel-wired-lan] [PATCH net-next v6 2/9] igc: Remove unused argument from igc_tx_cmd_type() In-Reply-To: <20210210215848.24514-3-vedang.patel@intel.com> References: <20210210215848.24514-1-vedang.patel@intel.com> <20210210215848.24514-3-vedang.patel@intel.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 10/02/2021 23:58, Vedang Patel wrote: > From: Andre Guedes > > The 'skb' argument from igc_tx_cmd_type() is not used so remove it. > > Signed-off-by: Andre Guedes > Reviewed-by: Maciej Fijalkowski > Signed-off-by: Vedang Patel > --- > drivers/net/ethernet/intel/igc/igc_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index 49748df61be7..261672797346 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -1029,7 +1029,7 @@ static inline int igc_maybe_stop_tx(struct igc_ring *tx_ring, const u16 size) > ((u32)((_input) & (_flag)) * ((_result) / (_flag))) : \ > ((u32)((_input) & (_flag)) / ((_flag) / (_result)))) > > -static u32 igc_tx_cmd_type(struct sk_buff *skb, u32 tx_flags) > +static u32 igc_tx_cmd_type(u32 tx_flags) > { > /* set type for advanced descriptor with frame checksum insertion */ > u32 cmd_type = IGC_ADVTXD_DTYP_DATA | > @@ -1078,7 +1078,7 @@ static int igc_tx_map(struct igc_ring *tx_ring, > u16 i = tx_ring->next_to_use; > unsigned int data_len, size; > dma_addr_t dma; > - u32 cmd_type = igc_tx_cmd_type(skb, tx_flags); > + u32 cmd_type = igc_tx_cmd_type(tx_flags); > > tx_desc = IGC_TX_DESC(tx_ring, i); > > Tested-by: Dvora Fuxbrumer