From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90C1EF9D0D6 for ; Tue, 14 Apr 2026 15:18:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 46B3F42AC1; Tue, 14 Apr 2026 15:18:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id fcs-QgiZBpsP; Tue, 14 Apr 2026 15:18:08 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8163542ABD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1776179888; bh=LGkcLUh8T7wLPcBQ8Z3nchLs+2qISFIMgueqO6SButM=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=yth+hql6axg7peBMg4Gy98ABMwMP+Co+7kpy4+r7oztrb6e6ItXypLFPkrq43jwkJ 4Kjhfh/rldnzkobIK96fYh4ruWw75bQjR5+UXJ7KY01iJ+zgMNAysxL8W/CaGxJmUb HCzIhi0toyrNSMR0cA7jUqg+q1xux00dgR8s0xXUCcuF1X/7I51yCxwxJMK74Adkv3 eB7/p4ZzFim8a1Jcv0kmn1G5/vy1bpUJ5Uae0JW3xa6OIYlrJhrsqFoOKpDZtm9wyx x9xxGjW8bbFEF6K4C3dKoLCYKNcuEtyLEr5tQ9bnBx+Lj3+cgcZU8wJVWCHGTwDiHt v7UuimxisARKQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 8163542ABD; Tue, 14 Apr 2026 15:18:08 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 3F407375 for ; Tue, 14 Apr 2026 15:18:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3CFF742ABB for ; Tue, 14 Apr 2026 15:18:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id FuZ4TYwFGi8U for ; Tue, 14 Apr 2026 15:18:06 +0000 (UTC) X-Greylist: delayed 430 seconds by postgrey-1.37 at util1.osuosl.org; Tue, 14 Apr 2026 15:18:05 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org E8DE342ABC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E8DE342ABC Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:37:1000::53df:5fcc:0; helo=mailout1.hostsharing.net; envelope-from=lukas@wunner.de; receiver= Received: from mailout1.hostsharing.net (mailout1.hostsharing.net [IPv6:2a01:37:1000::53df:5fcc:0]) by smtp4.osuosl.org (Postfix) with ESMTPS id E8DE342ABC for ; Tue, 14 Apr 2026 15:18:05 +0000 (UTC) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "*.hostsharing.net", Issuer "GlobalSign GCC R6 AlphaSSL CA 2025" (verified OK)) by mailout1.hostsharing.net (Postfix) with ESMTPS id E03F9383; Tue, 14 Apr 2026 17:10:50 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id C9EB86034192; Tue, 14 Apr 2026 17:10:50 +0200 (CEST) Date: Tue, 14 Apr 2026 17:10:50 +0200 From: Lukas Wunner To: "Loktionov, Aleksandr" Cc: "Tantilov, Emil S" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "Kitszel, Przemyslaw" , "Bhat, Jay" , "Barrera, Ivan D" , "Zaremba, Larysa" , "Nguyen, Anthony L" , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "Lobakin, Aleksander" , "linux-pci@vger.kernel.org" , "Chittim, Madhu" , "decot@google.com" , "willemb@google.com" , "sheenamo@google.com" Message-ID: References: <20260414031631.2107-1-emil.s.tantilov@intel.com> <20260414031631.2107-3-emil.s.tantilov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=wunner.de Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 2/2] idpf: implement pci error handlers X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Apr 14, 2026 at 11:09:05AM +0000, Loktionov, Aleksandr wrote: > > From: Tantilov, Emil S > > .slot_reset is the callback attempting to restore the device, provided > > a PCI reset was initiated by the AER driver. Just for clarity, those callbacks are invoked by PCI core error handling code and are shared by EEH, AER, DPC as well as s390 error recovery flows. So it's not only AER. > > +/** > > + * idpf_pci_err_resume - Resume operations after PCI error recovery > > + * @pdev: PCI device struct > > + */ > > +static void idpf_pci_err_resume(struct pci_dev *pdev) { > > + struct idpf_adapter *adapter = pci_get_drvdata(pdev); > > + > > + /* Force a PFR when resuming from PCI error. */ > > + if (test_and_set_bit(IDPF_PCI_CB_RESET, adapter->flags)) > > + adapter->dev_ops.reg_ops.trigger_reset(adapter, > > IDPF_HR_FUNC_RESET); > > You say "Force a PFR", but PFR is only triggered on the AER path, > not on the FLR path. And? idpf_pci_err_resume() is only invoked in the error recovery path (aka AER path), not FLR path AFAICS. Thanks, Lukas