From: Jacob Keller <jacob.e.keller@intel.com>
To: Joe Perches <joe@perches.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
<yexingchen116@gmail.com>, <anthony.l.nguyen@intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com, intel-wired-lan@lists.osuosl.org,
ye xingchen <ye.xingchen@zte.com.cn>,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH linux-next] iavf: Replace __FUNCTION__ with __func__
Date: Mon, 17 Oct 2022 15:58:28 -0700 [thread overview]
Message-ID: <ade90964-e8fe-c6d6-667d-133c36ad7c15@intel.com> (raw)
In-Reply-To: <a6d6e890c232775489daa9522c4f8dd9594b1656.camel@perches.com>
On 10/14/2022 8:10 AM, Joe Perches wrote:
> On Tue, 2022-10-11 at 14:46 -0700, Jesse Brandeburg wrote:
>> On 10/11/2022 4:16 AM, yexingchen116@gmail.com wrote:
>>> __FUNCTION__ exists only for backwards compatibility reasons with old
>>> gcc versions. Replace it with __func__.
> []
>>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> []
>>> @@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
>>> iavf_close(netdev);
>>>
>>> if (iavf_lock_timeout(&adapter->crit_lock, 5000))
>>> - dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __FUNCTION__);
>>> + dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __func__);
>
> Trivia: I suggest
>
> dev_warn(&adapter->pdev->dev, "%s: failed to acquire crit_lock\n", __func__);
>
> As almost all printed uses of __func__ use a form like
>
> <printk_variant>("%s: message\n", __func__);
>
> not
>
> <printk_variant>("message in %s\n", __func__);
>
I agree with Joe. Please fix this message up to use "%s: ...", __func__.
While at it, you might mention this fixes commit 226d528512cf ("iavf:
fix locking of critical sections") which introduced the use of __FUNCTION__.
Thanks,
Jake
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-10-17 22:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 11:16 [Intel-wired-lan] [PATCH linux-next] iavf: Replace __FUNCTION__ with __func__ yexingchen116
2022-10-11 21:46 ` Jesse Brandeburg
2022-10-14 15:10 ` Joe Perches
2022-10-17 22:58 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade90964-e8fe-c6d6-667d-133c36ad7c15@intel.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ye.xingchen@zte.com.cn \
--cc=yexingchen116@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox