From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DBE0FF8868 for ; Mon, 27 Apr 2026 15:58:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4491B60684; Mon, 27 Apr 2026 15:58:34 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yiKoqRM86Qh4; Mon, 27 Apr 2026 15:58:32 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0966860683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777305512; bh=HDuNa09IWvsLtfQxm277uKUgt69EWS0YpTX06KhV77M=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eKXn+0z3uN0zUJI62iF9o+V0oMPzfL1OLrolQHFTKBnwuokAlPJemmTGbqe4oKlTM b2dgBigDSdzvcb2KOao6q8GM/UO01yxfeyCzyimoUs53ik4y/BZ5bN8v2OvPgtqLYn YQ7cT6OCv6x6uQIxWyBLfgIwiFnKLkH+O0vogkXtxQLCMiFIsSgIjdDwprIfnTaq/G 9ns8bTEtgaQ2eDI37BakQ7vGf0RgcwgpLIJXbB7kgFaq3ZS0P6hNbbm4LUGHHLyM/T ghJSa1ELgKrZ2eE89o3gkCJtt8TJoWbtSqFyKjnyz0bNQeIp2vp//DpHucI6buUYpp SSDaOKtJoMpXA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 0966860683; Mon, 27 Apr 2026 15:58:32 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 6E71A231 for ; Mon, 27 Apr 2026 15:58:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 52662811C9 for ; Mon, 27 Apr 2026 15:58:31 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UpUFfw99L49b for ; Mon, 27 Apr 2026 15:58:30 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=vinschen@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 4909B811C8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4909B811C8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4909B811C8 for ; Mon, 27 Apr 2026 15:58:29 +0000 (UTC) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-z9vv6BunNjibkGWj_hACDg-1; Mon, 27 Apr 2026 11:58:24 -0400 X-MC-Unique: z9vv6BunNjibkGWj_hACDg-1 X-Mimecast-MFC-AGG-ID: z9vv6BunNjibkGWj_hACDg_1777305500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 957FF1944A8E; Mon, 27 Apr 2026 15:58:16 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.44.48.98]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 491A719560AB; Mon, 27 Apr 2026 15:58:16 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C0F71A8096D; Mon, 27 Apr 2026 17:58:13 +0200 (CEST) Date: Mon, 27 Apr 2026 17:58:13 +0200 From: Corinna Vinschen To: Jacob Keller Cc: Simon Horman , intel-wired-lan@osuosl.org, stable@vger.kernel.org, Jose Ignacio Tornos Martinez , netdev@vger.kernel.org, Corinna Vinschen Message-ID: Mail-Followup-To: Jacob Keller , Simon Horman , intel-wired-lan@osuosl.org, stable@vger.kernel.org, Jose Ignacio Tornos Martinez , netdev@vger.kernel.org References: <20260421111236.875379-1-vinschen@redhat.com> <20260423185530.GI900403@horms.kernel.org> <30b2fade-2545-4f2b-98ad-c6449512c04e@intel.com> MIME-Version: 1.0 In-Reply-To: <30b2fade-2545-4f2b-98ad-c6449512c04e@intel.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: DIMvUhF-F3bcpTlmKD-JIEccYALxKdv3WcHFlFMcZjE_1777305500 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777305508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HDuNa09IWvsLtfQxm277uKUgt69EWS0YpTX06KhV77M=; b=TUB9CUM5jbIeadCygJJ8lSN7/NF+Mlk6eWLopcNa/sOSqeCpig3+IWDPvp0q8OSWpXIxNB Cj5/JGEJE2ZKzJNX01HJE3l3Xm4W/5QhtZfCi4J9GbMKeI+62jwvrU+b59lqoxu12RvWiY 1mKxEvOfEMFDOL1sjL/lsCqCbM6Enl8= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TUB9CUM5 Subject: Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Apr 24 17:37, Jacob Keller wrote: > On 4/24/2026 1:32 AM, Corinna Vinschen wrote: > > On Apr 23 19:55, Simon Horman wrote: > >> On Tue, Apr 21, 2026 at 01:12:36PM +0200, Corinna Vinschen wrote: > >>> This is just a simple cleanup fix. Commit 35a2443d0910f ("iavf: Add > >>> waiting for response from PF in set mac") introduced a duplicate > >>> ether_addr_equal() check, so the current code tests the new MAC twice > >>> against the former MAC. > >>> > >>> Remove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b > >>> ("iavf: fix MAC address setting for VFs when filter is rejected") > >>> > >>> Signed-off-by: Corinna Vinschen > >>> Fixes: 35a2443d0910f ("iavf: Add waiting for response from PF in set mac") > >>> Reviewed-by: Aleksandr Loktionov > >>> --- > >>> Added CC: stable@vger.kernel.org > >> > >> Hi, > >> > >> This feels more like a cleanup for net-next (without a Fixes tag) > >> than a fix for net. I'm missing where the bug is here. > > > > Yeah, it's not a bug, the "Fixes" tag was just supposed to point out the > > patch introducing the duplicate test. > > > > Shall I create a v3 or is it ok as is and just goes to net-next instead > > of net? > > > > > > Thanks, > > Corinna > > > > I can make a note for later and either myself or Tony can forward it > net-next as part of an Intel Wired LAN update when the merge window > re-opens and any testing has completed. (Not that there is much needing > to be tested in this patches case) That's nice, thank you! Corinna