Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v1] iavf: Add waiting for response from PF in set mac
Date: Tue, 25 Jan 2022 23:21:49 +0000	[thread overview]
Message-ID: <ae8aeee37c90595fe8f2a1c3f289288964c11e1b.camel@intel.com> (raw)
In-Reply-To: <BL1PR11MB5288FC5E9F7779E972A1A43A875F9@BL1PR11MB5288.namprd11.prod.outlook.com>

On Tue, 2022-01-25 at 11:19 +0000, Palczewski, Mateusz wrote:
> > On Mon, 2022-01-24 at 16:45 +0100, Mateusz Palczewski wrote:
> > > Make iavf_set_mac synchronous by waiting for a response from a
> > > PF. 
> > > Without this iavf_set_mac is always returning success even though
> > > set_mac can be rejected by a PF.
> > > This ensures that when set_mac exits netdev MAC is updated.
> > > This is needed for sending ARPs with correct MAC after changing
> > > VF's 
> > > MAC. This is also needed by bonding module.
> > 
> > This sounds very much like this patch [1] or is this resolving a
> > different issue?
> Hi, 
> this is resolving a different issue that is being currently tracked
> on bugzilla:
> https://bugzilla.redhat.com/show_bug.cgi?id=1938635

Thanks for providing that info. I do have some feedback on the patch,
I'll reply to the original so that I can make them inline.

Thanks,
Tony

> > 
> > > Signed-off-by: Sylwester Dziedziuch
> > > <sylwesterx.dziedziuch@intel.com>
> > > Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
> > > ---
> > 
> > [1]
> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/
> > ?
> > id=c5c922b3e09b6e5eeb9cd2b1122f3e49c0bf2283
> 


  reply	other threads:[~2022-01-25 23:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 15:45 [Intel-wired-lan] [PATCH net-next v1] iavf: Add waiting for response from PF in set mac Mateusz Palczewski
2022-01-25  0:48 ` Nguyen, Anthony L
2022-01-25 11:19   ` Palczewski, Mateusz
2022-01-25 23:21     ` Nguyen, Anthony L [this message]
2022-01-25 23:36 ` Nguyen, Anthony L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae8aeee37c90595fe8f2a1c3f289288964c11e1b.camel@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox