Re: [Intel-wired-lan] [PATCH iwl-next v2 0/2] igc: enable build_skb path

Kohei Enju
2026-04-19T04:55:34Z

On 03/17 06:21, Kohei Enju wrote:
> This series enables the build_skb RX path in igc, which is currently not
> enabled in any configuration.
>
> Patch 1/2 adds missing RX hardware timestamp handling in the build_skb
> path.
> Patch 2/2 enables the build_skb path when XDP is inactive and other
> conditions are met.
>
> Tested on Intel Corporation Ethernet Controller I226-V (rev 04).
>
> Changes:
> v2:
> - don't insist on reverse christmas tree, reducing net diff in the
> patch 1/2 (Dima)
> v1: https://lore.kernel.org/intel-wired-lan/20260307182808.155027-1-kohei@enjuk.jp/
>
> Kohei Enju (2):
> igc: set RX hardware timestamps in igc_build_skb()
> igc: enable build_skb on the non-XDP small-frame RX path

Hi Tony,

Could you drop this series from Intel's queue?

Sashiko pointed out a potential use-after-free when dereferencing RX
hardware timestamps with build_skb enabled, and I believe this concern
is valid.
https://sashiko.dev/#/patchset/20260317062205.39406-1-kohei%40enjuk.jp

I'm working on a new series to address this problem.

Thanks,
Kohei