Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "naamax.meir" <naamax.meir@linux.intel.com>
To: Sasha Neftin <sasha.neftin@intel.com>,
	intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com
Cc: Vitaly Lifshits <vitaly.lifshits@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] intel: legacy: Partially revert of field get conversion
Date: Wed, 28 Feb 2024 12:38:50 +0200	[thread overview]
Message-ID: <aea66510-a12e-423f-87cf-92c2405e4e27@linux.intel.com> (raw)
In-Reply-To: <20240218074221.108927-1-sasha.neftin@intel.com>

On 2/18/2024 09:42, Sasha Neftin wrote:
> Refactoring of the field gets conversion introduced a regression in the
> legacy Wake On Lan from a magic packet with i219 devices. Rx address
> copied not correctly from MAC to PHY with FIELD_GET macro.
> 
> Fixes: b9a452545075 ("intel: legacy: field get conversion")
> Suggested-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>   drivers/net/ethernet/intel/e1000e/ich8lan.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Tested-by: Naama Meir <naamax.meir@linux.intel.com>

      reply	other threads:[~2024-02-28 10:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18  7:42 [Intel-wired-lan] [PATCH iwl-net v1 1/1] intel: legacy: Partially revert of field get conversion Sasha Neftin
2024-02-28 10:38 ` naamax.meir [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aea66510-a12e-423f-87cf-92c2405e4e27@linux.intel.com \
    --to=naamax.meir@linux.intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=sasha.neftin@intel.com \
    --cc=vitaly.lifshits@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox