From: "Neftin, Sasha" <sasha.neftin@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: "Edri, Michael" <michael.edri@intel.com>,
linux-pci@vger.kernel.org, "Nguyen,
Anthony L" <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Correct the short interval between PTM requests.
Date: Tue, 18 Jul 2023 19:15:02 +0300 [thread overview]
Message-ID: <af05bc6d-adf3-a0d1-534d-976f99e96d58@intel.com> (raw)
In-Reply-To: <80bfadb3-5af3-0100-30bb-c5008660d5a5@molgen.mpg.de>
On 7/17/2023 20:32, Paul Menzel wrote:
> [Cc: +linux-pci@vger.kernel.org]
>
> Dear Sasha,
>
>
> Thank you for your patch.
>
> Maybe be more specific in the commit message summary. Maybe:
>
> igc: Decrease PTM short interval from 10 us to 1 us
Good.
>
> Am 17.07.23 um 19:19 schrieb Sasha Neftin:
>> With the 10us interval, we were seeing PTM transactions taking around
>> 12us.
>> With the 1us interval, PTM dialogs took around 2us. Checked with the PCIe
>> sniffer.
>
> On what board, and with what device and what firmware versions?
Any with the PTM support. HW feature and not dependent on the firmware.
>
>> Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()")
>> Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>> ---
>> drivers/net/ethernet/intel/igc/igc_defines.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h
>> b/drivers/net/ethernet/intel/igc/igc_defines.h
>> index 44a507029946..c3722f524ea7 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
>> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
>> @@ -549,7 +549,7 @@
>> #define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x2f) << 2)
>> #define IGC_PTM_CTRL_PTM_TO(usec) (((usec) & 0xff) << 8)
>> -#define IGC_PTM_SHORT_CYC_DEFAULT 10 /* Default Short/interrupted
>> cycle interval */
>> +#define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle
>> interval */
>
> Why is the comment updated?
Interval, not interrupt...
>
>> #define IGC_PTM_CYC_TIME_DEFAULT 5 /* Default PTM cycle time */
>> #define IGC_PTM_TIMEOUT_DEFAULT 255 /* Default timeout for
>> PTM errors */
>
>
> Kind regards,
>
> Paul
Sasha
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-07-18 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 17:19 [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Correct the short interval between PTM requests Sasha Neftin
2023-07-17 17:32 ` Paul Menzel
2023-07-18 16:15 ` Neftin, Sasha [this message]
2023-07-18 22:37 ` Paul Menzel
2023-07-18 16:45 ` Bjorn Helgaas
2023-07-18 17:10 ` Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af05bc6d-adf3-a0d1-534d-976f99e96d58@intel.com \
--to=sasha.neftin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=michael.edri@intel.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox