From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E764FF886C for ; Tue, 28 Apr 2026 22:54:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id F0701403FB; Tue, 28 Apr 2026 22:54:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id V7p2uyPckxyT; Tue, 28 Apr 2026 22:54:57 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 74F104040F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777416897; bh=Xjifj32lQV5b+bLCm2NY5OLnoNmHIUz/l7KlvEd3nhA=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=yN5/ZF4xqOf5ga6F05meRDurb+tjc2RYEOt0D64I/JpQQ3+fenbzQpTUHQrJg8XB7 lG4Mb8fRF/cEPKK5tZvrr/8jY7L6MBvSYYmmENKQ0iiw4pVYHPUSeZvyM1hbQLaXzn pSNQAkULRxqNCGjjstX6V/u+DwQ6vXLwAb8+9y4mdqw1aPNz4DXQOuPnL48PuClPiv 3TPryfxMF3YDt4ZZMgqbHzvDvBSEUtzyroVp4bD4KPHmb+tX/Q9WvWbgggDAzJRHM3 bobzSULh+FbRTi0uumld/7Dfg1sNxFqlkGJ0j6oMsdnc62uOINn6XsI+HbNeyvPeXS Cu/MFEy4JEeqQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 74F104040F; Tue, 28 Apr 2026 22:54:57 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 060FE231 for ; Tue, 28 Apr 2026 14:59:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D77F2409B4 for ; Tue, 28 Apr 2026 14:59:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id o4dbvTQTmpVT for ; Tue, 28 Apr 2026 14:59:21 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::335; helo=mail-wm1-x335.google.com; envelope-from=error27@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org EEDC3409B0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EEDC3409B0 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by smtp4.osuosl.org (Postfix) with ESMTPS id EEDC3409B0 for ; Tue, 28 Apr 2026 14:59:20 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so140205095e9.0 for ; Tue, 28 Apr 2026 07:59:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777388359; x=1777993159; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xjifj32lQV5b+bLCm2NY5OLnoNmHIUz/l7KlvEd3nhA=; b=Di0b4syhHl7Lv3uIGUx4eX3sK8AvB9j20WXIQ8GaQmn2s7xZq90/yKd/Cs4ljyygHG zQItEt4DtvP7B2f9cZSAMPUN+Z4kjHuuQSn928UU6qo0KuwIG4eEnk03U05hPSxqFXke KoV59EQZ7w3Ye1kEE9dcvaf8qE/2rHzWuSV8YUafHXMKFd/LTwXt8CoKJuDVjSm7U1jm n9UvTDCHJY5mP4dvQHsdMvNTqcyko/LjqMRGeWCQ6QmSln/L24VtI2A3oc3rJwTz714c DDoiPGRjKSCq+UI7CH/kOfYidPYl/QwBAY+16jw8ZX160neK7kkqu684b03syg3OeDWC AlIQ== X-Forwarded-Encrypted: i=1; AFNElJ8JihgiOvGgBMT567mNlcau/5V1tLYHDLYtgEkSzgXJFT093ifAjPIedxkuJQ8PwrGYuLF2Bp8p4sbpDMT+T5c=@lists.osuosl.org X-Gm-Message-State: AOJu0Yw54YB9WIB4hPn0qkk/PVPg3WxINS2QV57mah1wvwppOVhco2KW i5ArJSBfPJbT5spLJJvVrr3gucbTvtGFEouGQj3TK0vabi4QXstztZTF X-Gm-Gg: AeBDieswlzYKsV/aABSBS1AvYRtloxsDF0s5qtdH0Tg+HTLE5mT1/SbLs3bqQaCN8Ii V1vZ+Fv2Acw8x9BAozZjMQDYzX/4bNHMcmM65icOcu2J/io4dO+r78D1Z/EVkOcXQjwr082Ngo8 KgvKMRRN8vFIdOs74KiTJDj3jS3+tK0Qf7n3FnSeODMQFVhDPOflgrgdKH5UVWMyhkx5znO0L4V xaYqHWetGal3h/t248ya89e4xC3bNabwrwLyXmNQE2ClHQFgslphcsubZDN4znG00WCIRKxSI+m rUuKzqdYSywP11swcJaPz6M6tBsTWiG7VvHPyFFSCBcH/Pyws0Odaeb5Pl1vN5qazbq34B5KbTL KjzC6iKn1A17SPWORKR+m4Yw+yBqoWsabKMZzf34kLwXsGwZa/UIBkzM8BcEkJGjAjqAtuJvhNa 1mbe1g2J+7b+pp9nTWqailY+WOalGT9w== X-Received: by 2002:a05:600c:a315:b0:488:9e54:94c0 with SMTP id 5b1f17b1804b1-48a77adc73dmr39426575e9.8.1777388358658; Tue, 28 Apr 2026 07:59:18 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a775ea85bsm31476575e9.6.2026.04.28.07.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 07:59:17 -0700 (PDT) Date: Tue, 28 Apr 2026 17:59:13 +0300 From: Dan Carpenter To: Przemek Kitszel Cc: Jakub Raczynski , netdev@vger.kernel.org, kuba@kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Message-ID: References: <20260428103653.3539239-1-j.raczynski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Tue, 28 Apr 2026 22:54:54 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777388359; x=1777993159; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xjifj32lQV5b+bLCm2NY5OLnoNmHIUz/l7KlvEd3nhA=; b=qcuXjbDFpBWHmQBMMtJJqMIfJc0ODHQMnbD0851txtSqxX3SyAA7yDlie87VQQZLUm J2So3kO7YDUOuUWI8cQpgLbiP+HmmIXRqd4qfYDMYS9bVthHHzR8Vb87dzhkfIP/iXmr A8HTT+C6IK22mZVYQ6iE0Wv2kU6CLkEDXy1SPCglipeV2e3WJlHBcHmmRf9zR4Px7iTW ZH0XuO0lXGYXir01JRXYNdJjAkOpDo4dmdWiRFHtfJNdVAeQvfbfi2omtAqT5UzPsn5Z MZT16GjELmkYm+RNf+ynkbKzm2H7uEN4l10a0CSIafMmhsfStph9STb8V/pob9yeTt2J 6Vrw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=qcuXjbDF Subject: Re: [Intel-wired-lan] [PATCH v3 net-next] net/intel: Replace manual array size calculation with ARRAY_SIZE X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Apr 28, 2026 at 04:06:48PM +0200, Przemek Kitszel wrote: > On 4/28/26 12:36, Jakub Raczynski wrote: > > There are still places in the code where manual calculation of array size > > exist, but it is good to enforce usage of single macro through the whole > > code as it makes code bit more readable. > > While at it, beautify condition surrounding it by reversing check and remove > > unnecessary casting. > > > > Signed-off-by: Jakub Raczynski > > Reviewed-by: Dan Carpenter > > thank you, > Reviewed-by: Przemek Kitszel > > (next time use "iwl-next" in the title, no need to repost just for that) > These prefixes are a headache. It seems like no big deal if you only work on one subsystem, but if you're dealing with tree wide code then we're dealing with 418 trees. These days I have a script for net and net-next because they are a high volume list and the original prefix subsystem. But otherwise it just automatically puts [PATCH next] if it's in linux-next or [PATCH] if it's in Linus's tree. These are all automatic on my end, right? So it would be totally possible to automate in the recieving side instead. Although in this case, my script would net-next in the subject because I had no idea that Intel was managing their own ethernet drivers... It used to be that wireless had their own tree and everything else went through net. So it's just seems like a in impossible task to keep track of it all even if you are not a newbie. :/ regards, dan carpenter