From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C9B4C43458 for ; Thu, 2 Jul 2026 14:35:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 404F083B3C; Thu, 2 Jul 2026 14:35:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id G9Elxw4hG0gK; Thu, 2 Jul 2026 14:35:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 859AB83B3B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1783002944; bh=wH9rv6AxNmdVYoJg0T3cBY47n1twfT656Q2yRzOY/xI=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PXea41SJraNo38wZCjrlDOWS6Cw7JQlxgtwgHiMnPvtKJUYNzD8n7gF8mnzli9NEH y05PlZ09odwDjL4/+rd4A6y2xUZT4vkNvpqPwyG/U+D2CaeGzoUa0vTIj1Ej8EGKJw hAOONcCUEwBc1IHeMBJBxp2YLCVIK5FF6r8Gf5NPoaTea8/4aS5wsUIChKUTzsdzTa BjOsYgk2xyyKWfis34HNe3whMAyPETF98aa/zvRuE88B0b6lLIse+CqhvhisPr5iTj xVbDWVp6PZLeMEFsKYqTDKkWWxaAs3Qhrj20Pde+whf6GCJAb3VKImJtUByIPLv/AW 5L137APTGFCmA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 859AB83B3B; Thu, 2 Jul 2026 14:35:44 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 9DD43127 for ; Thu, 2 Jul 2026 14:35:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 83B2940EBF for ; Thu, 2 Jul 2026 14:35:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id XBvV4mw5YXG6 for ; Thu, 2 Jul 2026 14:35:42 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=rppt@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org CD33B4033F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org CD33B4033F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp2.osuosl.org (Postfix) with ESMTPS id CD33B4033F for ; Thu, 2 Jul 2026 14:35:41 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1FA7E43542; Thu, 2 Jul 2026 14:35:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9276F1F000E9; Thu, 2 Jul 2026 14:35:37 +0000 (UTC) Date: Thu, 2 Jul 2026 17:35:34 +0300 From: Mike Rapoport To: Przemek Kitszel Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Manish Chopra , Paolo Abeni , Edward Cree , Sudarsana Kalluru , Tony Nguyen , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-net-drivers@amd.com, netdev@vger.kernel.org Message-ID: References: <20260701-b4-drivers-ethernet-v1-0-58776615db6e@kernel.org> <20260701-b4-drivers-ethernet-v1-1-58776615db6e@kernel.org> <02237688-9532-4fd0-8494-a7bb524ca4f2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02237688-9532-4fd0-8494-a7bb524ca4f2@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783002941; bh=wH9rv6AxNmdVYoJg0T3cBY47n1twfT656Q2yRzOY/xI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mEQ4xknizAwN9m9BBuGqodJtOesHR1ePpcgaFcVl6YLkUgpkmhQNwKJYORN0RL5aF Zap7xy7QCA5EX2jc+RjnYkBghVkLQf0NjvYHMD4tLjcHgYHcH8XBZ+HsZOAjvFrxmh A/TqLdLqF5kjtdjg7m4aGrJMbqzRP9MlAgaskdofaJoNtgjsRuB5ABSs6Xx0x9Jzko DMSkjzLGGfKy4hDC9e7AjonGgU4uifZFcqqvZwprngUIFYE9iWHd4LTH6JGEUGLNIQ h6QrGBZQ/H80taGOJwizJrsrEzSuVqY0v9sjHpJnOe+cO/eIpPsxu73DhapD9oPms5 2khvfGU+SZc5w== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mEQ4xkni Subject: Re: [Intel-wired-lan] [PATCH 1/4] bnx2x: use kzalloc() to allocate mac filtering list X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jul 02, 2026 at 03:52:13PM +0200, Przemek Kitszel wrote: > > > @@ -2713,8 +2714,7 @@ static int bnx2x_mcast_enqueue_cmd(struct bnx2x *bp, > > total_elems = BNX2X_MCAST_BINS_NUM; > > } > > while (total_elems > 0) { > > - elem_group = (struct bnx2x_mcast_elem_group *) > > - __get_free_page(GFP_ATOMIC | __GFP_ZERO); > > + elem_group = kzalloc(PAGE_SIZE, GFP_ATOMIC); > > what is the current rule of thumb for kzalloc vs kvzalloc size under > GFP_ATOMIC? kvzalloc() with GFP_ATOMIC is kzalloc(): /* * vmalloc uses GFP_KERNEL for some internal allocations (e.g page tables) * so the given set of flags has to be compatible. */ if ((flags & GFP_KERNEL) != GFP_KERNEL) return kmalloc_node(size, flags, node); so it's only physically contiguous allocations. > > if (!elem_group) { > > bnx2x_free_groups(&new_cmd->group_head); > > kfree(new_cmd); > > > -- Sincerely yours, Mike.