From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ADB8CF2564 for ; Sat, 12 Oct 2024 12:06:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B9742402D0; Sat, 12 Oct 2024 12:06:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TXwFsnheDr4O; Sat, 12 Oct 2024 12:06:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B423840383 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1728734791; bh=4q+5yM/yTzJBMrMhD9gLrCWAQ7obBGvJ5w2ryoNvuqE=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=wgON1Z32bIT+NTPDMqHNvna1UnfSN0mTMKjRGSmNy3YYOxcyCrX5aC+x0t+koi+ZD H7aOw0U9M8ss7pq5/pMHgq5ouv1uAtl3rqFTMvo6FFSkD7AINQttJSggrUQNeEvHeS cfdTFqUlbgfvxkPoByRn5oqPs5w1UYo0GdA1oNl4XmPfNvFRPh2yzL4P7K/xGmZDgL kB3K8a7JEVm/mqNF/Pb1XeXh5nStx6LRMRNbdfs4U97ExAQONNmGhRbbkmlAx7ndIQ FwXGWxzUPIHxibCU8AVEGkhzSb4AwKmR8BBH2BESKkjgNjpyPMVRPwVw0IslZTj8ab 5x+T/Ag2oCgng== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id B423840383; Sat, 12 Oct 2024 12:06:31 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 6C74B1BF2F8 for ; Sat, 12 Oct 2024 12:06:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 591AE4030D for ; Sat, 12 Oct 2024 12:06:30 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id CU0GcGh_-Fky for ; Sat, 12 Oct 2024 12:06:29 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=45.249.212.188; helo=szxga02-in.huawei.com; envelope-from=linyunsheng@huawei.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org D0651402F7 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D0651402F7 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by smtp4.osuosl.org (Postfix) with ESMTPS id D0651402F7 for ; Sat, 12 Oct 2024 12:06:28 +0000 (UTC) Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XQhvv1XPnzkWcD; Sat, 12 Oct 2024 20:03:07 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 66A98140393; Sat, 12 Oct 2024 20:05:32 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 12 Oct 2024 20:05:32 +0800 Message-ID: Date: Sat, 12 Oct 2024 20:05:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: , , References: <20240925075707.3970187-1-linyunsheng@huawei.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: <20240925075707.3970187-1-linyunsheng@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemf200006.china.huawei.com (7.185.36.61) X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Subject: Re: [Intel-wired-lan] [PATCH net v2 0/2] fix two bugs related to page_pool X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mediatek@lists.infradead.org, Jesper Dangaard Brouer , Daniel Borkmann , netdev@vger.kernel.org, John Fastabend , Alexei Starovoitov , Alexander Duyck , linux-kernel@vger.kernel.org, Alexander Lobakin , IOMMU , liuyonglong@huawei.com, Matthias Brugger , zhangkun09@huawei.com, fanghaiqing@huawei.com, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Robin Murphy , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2024/9/25 15:57, Yunsheng Lin wrote: > Patch 1 fix a possible time window problem for page_pool. > Patch 2 fix the kernel crash problem at iommu_get_dma_domain > reported in [1]. Hi, all Through the discussions, it seems there are some main concerns as below: 1. Semantics changing of supporting unlimited inflight pages to limited inflight pages that are as large as the pool_size of page_pool. 2. The overhead of finding available pool->items in page_pool_item_add(). Any other concerns I missed here? As it is unclear about the impact of the above concerns, which seemed to lead Paolo to suggest this patchset targetting net-next tree instead of net tree, so I am planning to target the net-next tree keeping the 'Fixes' tag for the next version, if there is any other opinion here, please let me know. Also, I still have the page_frag refactoring patchset pending in the nex-next, please let me know if I should wait for that patchset to be applied before sending this one to the net-next tree. >