From: Desouza, Ederson <ederson.desouza@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH next-queue v1 2/2] igc: enable auxiliary PHC functions for the i225
Date: Thu, 18 Feb 2021 00:27:55 +0000 [thread overview]
Message-ID: <b42bc3f694b5d30f4bee163b65552a5d65d20706.camel@intel.com> (raw)
In-Reply-To: <4a11d17d2b0b2e297de1e42fb76db076e9940712.camel@intel.com>
On Wed, 2021-02-17 at 23:53 +0000, Nguyen, Anthony L wrote:
> On Mon, 2021-02-15 at 11:05 +0100, Paul Menzel wrote:
> > Dear Ederson,
> >
> >
> > Am 12.02.21 um 02:42 schrieb Ederson de Souza:
> > > The i225 device offers a number of special PTP Hardware Clock
> > > features on
> > > the Software Defined Pins (SDPs). This patch adds support for two
> > > of the
> > > possible functions, namely time stamping external events, and
> > > periodic
> > > output signals.
> > >
> > > The assignment of PHC functions to the four SDP can be freely
> > > chosen by
> > > the user.
> > >
> > > While i225 allows up to four timers to be used to source the time
> > > used
> > > on the external events or output signals, this patch uses only one
> > > of
> > > those timers.
> >
> > Why is that? Because it?s simpler to implement? Please add the reason
> > to
> > the commit message.
>
> I've applied this patch so testing can be done, but I agree with Paul.
> Some detail on why only one timer is being used would be nice.
>
> Also, there are quite a few check/warnings from checkpatch that look
> like they can easily be remedied.
Sure, I'll address the review comments and checks and send a v2 soon.
Thanks for the reviews!
>
> Thanks,
> Tony
prev parent reply other threads:[~2021-02-18 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 1:42 [Intel-wired-lan] [PATCH next-queue v1 0/2] PPS and SDP support for i225 Ederson de Souza
2021-02-12 1:42 ` [Intel-wired-lan] [PATCH next-queue v1 1/2] igc: Enable internal i225 PPS Ederson de Souza
2021-02-16 9:38 ` Paul Menzel
2021-02-12 1:42 ` [Intel-wired-lan] [PATCH next-queue v1 2/2] igc: enable auxiliary PHC functions for the i225 Ederson de Souza
2021-02-15 10:05 ` Paul Menzel
2021-02-17 23:53 ` Nguyen, Anthony L
2021-02-18 0:27 ` Desouza, Ederson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b42bc3f694b5d30f4bee163b65552a5d65d20706.camel@intel.com \
--to=ederson.desouza@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox