From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Palczewski, Mateusz" <mateusz.palczewski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: Fix max VLANs available for VF
Date: Tue, 28 Jun 2022 15:35:03 -0700 [thread overview]
Message-ID: <b4c4fbca-10cb-8d11-c58f-8dfc129b90dd@intel.com> (raw)
In-Reply-To: <20220628123350.677880-1-mateusz.palczewski@intel.com>
On 6/28/2022 5:33 AM, Palczewski, Mateusz wrote:
> Legacy VLAN implementation allows for untrusted VF to have 8 VLAN
> filters, not counting VLAN 0 filters. Current VLAN_V2 implementation
> lowers available filters for VF, by counting in VLAN 0 filter for both
> TPIDs.
> Fix this by counting only non zero VLAN filters.
> Without this patch, untrusted VF would not be able to access 8 VLAN
> filters.
>
> Fixes: cc71de8fa133 ("ice: Add support for VIRTCHNL_VF_OFFLOAD_VLAN_V2")
> Signed-off-by: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
As Olek pointed out, please fix your email settings [1].
From:/Signed-off-by: email name mismatch: 'From: "Palczewski, Mateusz"
<mateusz.palczewski@intel.com>' != 'Signed-off-by: Mateusz Palczewski
<mateusz.palczewski@intel.com>'
However, based on ordering, shouldn't the author be Przemyslaw?
[1]
https://lore.kernel.org/intel-wired-lan/20220628141911.1403944-1-alexandr.lobakin@intel.com/T/#m20c8d8eb342f31bdbf88f1976a484a04bf049554
> ---
> v2: Changed fixes tag
> ---
> drivers/net/ethernet/intel/ice/ice_virtchnl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl.c b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> index 4547bc1f7cee..24188ec594d5 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> @@ -2948,7 +2948,8 @@ ice_vc_validate_add_vlan_filter_list(struct ice_vsi *vsi,
> struct virtchnl_vlan_filtering_caps *vfc,
> struct virtchnl_vlan_filter_list_v2 *vfl)
> {
> - u16 num_requested_filters = vsi->num_vlan + vfl->num_elements;
> + u16 num_requested_filters = ice_vsi_num_non_zero_vlans(vsi) +
> + vfl->num_elements;
>
> if (num_requested_filters > vfc->max_filters)
> return false;
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-06-28 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 12:33 [Intel-wired-lan] [PATCH net v2] ice: Fix max VLANs available for VF Palczewski, Mateusz
2022-06-28 22:35 ` Tony Nguyen [this message]
2022-06-28 22:36 ` Nguyen, Anthony L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4c4fbca-10cb-8d11-c58f-8dfc129b90dd@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=mateusz.palczewski@intel.com \
--cc=przemyslawx.patynowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox