From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Brett Creeley <brett.creeley@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v9 4/5] ice: enable FW logging based on stored configuration
Date: Fri, 3 Mar 2023 15:22:31 -0800 [thread overview]
Message-ID: <b7a5e4b8-cbf6-04eb-017a-b8629429f763@intel.com> (raw)
In-Reply-To: <20230302215109.124-5-paul.m.stillwell.jr@intel.com>
On 3/2/2023 1:51 PM, Paul M Stillwell Jr wrote:
[...]
> +int ice_fwlog_set(struct ice_hw *hw, struct ice_fwlog_cfg *cfg)
> +{
> + int status;
> +
> + if (!ice_fwlog_supported(hw))
> + return -EOPNOTSUPP;
> +
> + if (!valid_cfg(hw, cfg))
> + return -EINVAL;
> +
> + status = ice_aq_fwlog_set(hw, cfg->module_entries,
> + ICE_AQC_FW_LOG_ID_MAX, cfg->options,
> + cfg->log_resolution);
Return here, no need to assign to status
> +
> + return status;
> +}
> +
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-03-03 23:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 21:51 [Intel-wired-lan] [PATCH net-next v9 0/5] add v2 FW logging for ice driver Paul M Stillwell Jr
2023-03-02 21:51 ` [Intel-wired-lan] [PATCH net-next v9 1/5] ice: remove FW logging code Paul M Stillwell Jr
2023-03-02 21:51 ` [Intel-wired-lan] [PATCH net-next v9 2/5] ice: enable debugfs to check FW logging status Paul M Stillwell Jr
2023-03-03 23:21 ` Tony Nguyen
2023-03-06 22:00 ` Paul M Stillwell Jr
2023-03-02 21:51 ` [Intel-wired-lan] [PATCH net-next v9 3/5] ice: add ability to set FW log configuration Paul M Stillwell Jr
2023-03-03 1:23 ` kernel test robot
2023-03-03 23:21 ` Tony Nguyen
2023-03-06 22:11 ` Paul M Stillwell Jr
2023-03-02 21:51 ` [Intel-wired-lan] [PATCH net-next v9 4/5] ice: enable FW logging based on stored configuration Paul M Stillwell Jr
2023-03-03 23:22 ` Tony Nguyen [this message]
2023-03-06 22:14 ` Paul M Stillwell Jr
2023-03-02 21:51 ` [Intel-wired-lan] [PATCH net-next v9 5/5] ice: add ability to enable FW logging and capture data Paul M Stillwell Jr
2023-03-03 23:23 ` Tony Nguyen
2023-03-08 23:22 ` Paul M Stillwell Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7a5e4b8-cbf6-04eb-017a-b8629429f763@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=brett.creeley@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=paul.m.stillwell.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox