Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH intel-net 2/5] ice: xsk: allocate separate memory for XDP SW ring
Date: Fri, 10 Dec 2021 21:05:29 +0000	[thread overview]
Message-ID: <b7ccf744f0fc8959991e5f4071953b260ae55f7a.camel@intel.com> (raw)
In-Reply-To: <20211210145941.5865-3-maciej.fijalkowski@intel.com>

On Fri, 2021-12-10 at 15:59 +0100, Maciej Fijalkowski wrote:
> @@ -425,9 +430,8 @@ static void ice_bump_ntc(struct ice_rx_ring
> *rx_ring)
> ? * Returns the skb on success, NULL on failure.
> ? */
> ?static struct sk_buff *
> -ice_construct_skb_zc(struct ice_rx_ring *rx_ring, struct xdp_buff
> **xdp_arr)
> +ice_construct_skb_zc(struct ice_rx_ring *rx_ring, struct xdp_buff
> *xdp)

There's a kdoc issue here.

drivers/net/ethernet/intel/ice/ice_xsk.c:436: warning: Function
parameter or member 'xdp' not described in 'ice_construct_skb_zc'
drivers/net/ethernet/intel/ice/ice_xsk.c:436: warning: Excess function
parameter 'xdp_arr' description in 'ice_construct_skb_zc'

Thanks,
Tony


  reply	other threads:[~2021-12-10 21:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 14:59 [Intel-wired-lan] [PATCH intel-net 0/5] ice: xsk: Rx processing fixes Maciej Fijalkowski
2021-12-10 14:59 ` [Intel-wired-lan] [PATCH intel-net 1/5] ice: xsk: return xsk buffers back to pool when cleaning the ring Maciej Fijalkowski
2021-12-10 14:59 ` [Intel-wired-lan] [PATCH intel-net 2/5] ice: xsk: allocate separate memory for XDP SW ring Maciej Fijalkowski
2021-12-10 21:05   ` Nguyen, Anthony L [this message]
2021-12-10 22:24   ` Alexander Lobakin
2021-12-13 11:14     ` Maciej Fijalkowski
2021-12-10 14:59 ` [Intel-wired-lan] [PATCH intel-net 3/5] ice: xsk: do not clear status_error0 for ntu + nb_buffs descriptor Maciej Fijalkowski
2021-12-10 22:37   ` Alexander Lobakin
2021-12-13 11:12     ` Maciej Fijalkowski
2021-12-13 11:26       ` Alexander Lobakin
2021-12-13 11:33         ` Maciej Fijalkowski
2021-12-13 11:43           ` Alexander Lobakin
2021-12-13 12:53       ` Magnus Karlsson
2021-12-10 14:59 ` [Intel-wired-lan] [PATCH intel-net 4/5] ice: xsk: allow empty Rx descriptors on XSK ZC data path Maciej Fijalkowski
2021-12-10 14:59 ` [Intel-wired-lan] [PATCH intel-net 5/5] ice: xsk: fix cleaned_count setting Maciej Fijalkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7ccf744f0fc8959991e5f4071953b260ae55f7a.camel@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox