Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Brian Vazquez <brianvv@google.com>
Cc: Brian Vazquez <brianvv.kernel@gmail.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	<intel-wired-lan@lists.osuosl.org>,
	David Decotigny <decot@google.com>,
	"Vivek Kumar" <vivekmr@google.com>,
	Anjali Singhai <anjali.singhai@intel.com>,
	Sridhar Samudrala <sridhar.samudrala@intel.com>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<emil.s.tantilov@intel.com>,
	Marco Leogrande <leogrande@google.com>,
	"Manoj Vishwanathan" <manojvishy@google.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Subject: Re: [Intel-wired-lan] [iwl-next PATCH v4 2/3] idpf: convert workqueues to unbound
Date: Mon, 16 Dec 2024 19:10:44 +0100	[thread overview]
Message-ID: <b81501de-7dd3-4808-920e-14b2cc817038@intel.com> (raw)
In-Reply-To: <20241216162735.2047544-3-brianvv@google.com>

From: Brian Vazquez <brianvv@google.com>
Date: Mon, 16 Dec 2024 16:27:34 +0000

> From: Marco Leogrande <leogrande@google.com>
> 
> When a workqueue is created with `WQ_UNBOUND`, its work items are
> served by special worker-pools, whose host workers are not bound to
> any specific CPU. In the default configuration (i.e. when
> `queue_delayed_work` and friends do not specify which CPU to run the
> work item on), `WQ_UNBOUND` allows the work item to be executed on any
> CPU in the same node of the CPU it was enqueued on. While this
> solution potentially sacrifices locality, it avoids contention with
> other processes that might dominate the CPU time of the processor the
> work item was scheduled on.
> 
> This is not just a theoretical problem: in a particular scenario
> misconfigured process was hogging most of the time from CPU0, leaving
> less than 0.5% of its CPU time to the kworker. The IDPF workqueues
> that were using the kworker on CPU0 suffered large completion delays
> as a result, causing performance degradation, timeouts and eventual
> system crash.

Wasn't this inspired by [0]?

[0]
https://lore.kernel.org/netdev/20241126035849.6441-11-milena.olech@intel.com

Thanks,
Olek

  reply	other threads:[~2024-12-16 18:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 16:27 [Intel-wired-lan] [iwl-next PATCH v4 0/3] IDPF Virtchnl: Enhance error reporting & fix locking/workqueue issues Brian Vazquez
2024-12-16 16:27 ` [Intel-wired-lan] [iwl-next PATCH v4 1/3] idpf: Acquire the lock before accessing the xn->salt Brian Vazquez
2025-01-14  6:58   ` Singh, Krishneil K
2024-12-16 16:27 ` [Intel-wired-lan] [iwl-next PATCH v4 2/3] idpf: convert workqueues to unbound Brian Vazquez
2024-12-16 18:10   ` Alexander Lobakin [this message]
2024-12-16 20:13     ` Brian Vazquez
2025-01-14  7:00       ` Singh, Krishneil K
2024-12-16 16:27 ` [Intel-wired-lan] [iwl-next PATCH v4 3/3] idpf: add more info during virtchnl transaction timeout/salt mismatch Brian Vazquez
2025-01-14  7:00   ` Singh, Krishneil K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b81501de-7dd3-4808-920e-14b2cc817038@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=anjali.singhai@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=brianvv.kernel@gmail.com \
    --cc=brianvv@google.com \
    --cc=davem@davemloft.net \
    --cc=decot@google.com \
    --cc=edumazet@google.com \
    --cc=emil.s.tantilov@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=leogrande@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manojvishy@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.kumar.linga@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=vivekmr@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox