From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: Fix VSIs unable to share unicast MAC
Date: Thu, 14 Jul 2022 13:33:48 -0700 [thread overview]
Message-ID: <bbcc1814-38e3-eba2-b65c-dab4ac7cecda@intel.com> (raw)
In-Reply-To: <20220714135107.46473-1-jedrzej.jagielski@intel.com>
On 7/14/2022 6:51 AM, Jedrzej Jagielski wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h
> index f2a518a1fd94..bef7c3ba1a20 100644
> --- a/drivers/net/ethernet/intel/ice/ice_type.h
> +++ b/drivers/net/ethernet/intel/ice/ice_type.h
> @@ -889,7 +889,8 @@ struct ice_hw {
> /* INTRL granularity in 1 us */
> u8 intrl_gran;
>
> - u8 ucast_shared; /* true if VSIs can share unicast addr */
> + /* true if VSIs can share unicast MAC addr */
> + u8 umac_shared;
Same comment as v1. This doesn't look needed at all as it never changes;
it could be removed and conditions updated.
> #define ICE_PHY_PER_NAC 1
> #define ICE_MAX_QUAD 2
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-07-14 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 13:51 [Intel-wired-lan] [PATCH net v2] ice: Fix VSIs unable to share unicast MAC Jedrzej Jagielski
2022-07-14 13:58 ` Jagielski, Jedrzej
2022-07-14 20:33 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbcc1814-38e3-eba2-b65c-dab4ac7cecda@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
--cc=sylwesterx.dziedziuch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox