From: Andrew Lunn <andrew@lunn.ch>
To: Jeff Daly <jeffd@silicom-usa.com>
Cc: przemyslaw.kitszel@intel.com, linux-kernel@vger.kernel.org,
edumazet@google.com, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH] ixgbe: Manual AN-37 for troublesome link partners for X550 SFI
Date: Fri, 6 Sep 2024 17:54:49 +0200 [thread overview]
Message-ID: <becaaeaf-e76a-43d2-b6e1-e7cc330d8cae@lunn.ch> (raw)
In-Reply-To: <20240906104145.9587-1-jeffd@silicom-usa.com>
On Fri, Sep 06, 2024 at 06:41:45AM -0400, Jeff Daly wrote:
> Resubmit commit 565736048bd5 ("ixgbe: Manual AN-37 for troublesome link
> partners for X550 SFI")
>
> Some (Juniper MX5) SFP link partners exhibit a disinclination to
> autonegotiate with X550 configured in SFI mode. This patch enables
> a manual AN-37 restart to work around the problem.
>
> Resubmitted patch includes a module parameter (default disabled) to
> isolate changes.
Module parameters are not liked in networking code. They are very user
unfriendly, and poorly documented.
Why do you need it? Is this change risky?
Andrew
next prev parent reply other threads:[~2024-09-06 15:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 10:41 [Intel-wired-lan] [PATCH] ixgbe: Manual AN-37 for troublesome link partners for X550 SFI Jeff Daly
2024-09-06 15:54 ` Andrew Lunn [this message]
2024-09-06 20:49 ` Jeff Daly
2024-09-06 21:16 ` Andrew Lunn
2024-09-09 15:46 ` Jeff Daly
2024-09-09 19:35 ` Andrew Lunn
2024-09-10 17:51 ` Jeff Daly
-- strict thread matches above, loose matches on Subject: below --
2022-05-10 10:55 Skajewski, PiotrX
2022-03-16 19:27 Jeff Daly
2022-03-18 23:47 ` Tony Nguyen
2022-05-12 17:09 ` Tony Nguyen
2022-07-19 13:30 ` Jeff Daly
2022-07-20 21:39 ` Tony Nguyen
2022-05-11 8:26 ` Piotr Skajewski
2022-03-16 19:24 Jeff Daly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=becaaeaf-e76a-43d2-b6e1-e7cc330d8cae@lunn.ch \
--to=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffd@silicom-usa.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox