From: Neftin, Sasha <sasha.neftin@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1] igc: Add set_rx_mode support
Date: Thu, 19 Sep 2019 15:56:41 +0300 [thread overview]
Message-ID: <bedf2d12-9a0e-2633-2d02-27c35d03fc35@intel.com> (raw)
In-Reply-To: <c83ff718-22e6-996f-7dea-b16317e1a969@redhat.com>
On 9/19/2019 14:49, David Arcari wrote:
> On 09/19/2019 01:48 AM, Neftin, Sasha wrote:
>> On 9/18/2019 23:29, Alexander Duyck wrote:
>>> On Wed, Sep 18, 2019 at 12:29 PM David Arcari <darcari@redhat.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> On 09/10/2019 03:05 AM, Sasha Neftin wrote:
>>>>> Add multicast addresses list to the MTA table.
>>>>> Implement promiscious mode and add basic rx mode support.
>>>>> Add option for ipv6 address settings.
>>>>>
>>>>> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>>>>
>>>> This seems to break ipv4 communication over vlans:
>>>
>> Please, use follow commands for ipv6:
>> ip -6 addr add <ipv6address>/<prefixlength> dev <interface>
>>
>> Example:
>> sudo ip -6 addr add fe80::2a0:c9ff:fe00:2/64 dev enp5s0
>>
>> Remove ipv6 address:
>> sudo ip -6 addr del fe80::2a0:c9ff:fe00:2/64 dev enp5s0
>>
>> ping -6 -I <interface> <address>
>> Example:
>> ping -6 -I enp4s0 fe80::2a0:c9ff:fe00:1
>> I've checked it on my side and looks ipv4 and ipv6 works.
>
> I'm no longer having connectivity issue with ipv6 with this commit applied.
>
Thanks to confirming that.
>> Let me not agree with you in regards to break ipv4 communication over
>> vlan. Since vlan not supported yet it can not be broken.
>
> Well - interestingly enough vlan connectivity was working for ipv4 before this
> commit. I guess it was just good fortune.
>
> -DA
>
Interesting. Okay, anyway, I plan add vlan support in future and will
share with you.
Sasha
>
>> I am working to add VLAN support in my next patches.
>>
>>> Why is this code messing with the VLANs? The patch description says it
>>> is enabling multicast and the MTA but it is messing with the VFTA
>>> table as well. That is probably what broke the VLANs.
>>>
>>> I don't see the bits to support ndo_vlan_rx_[add|kill]_vid and without
>>> that it will break VLANs since the driver is filtering them unless
>>> promiscuous filtering is enabled. The VLAN changes should be moved
>>> into a separate patch.
>>>
>> You are right. Few lines related to VFTA present here. Sorry about that.
>> I did not mention add support for VLAN tagged frames in this patch. I
>> plan to add VLAN support in my next patches.
>> Sasha
>>
>
next prev parent reply other threads:[~2019-09-19 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 7:05 [Intel-wired-lan] [PATCH v1] igc: Add set_rx_mode support Sasha Neftin
2019-09-14 0:46 ` Vinicius Costa Gomes
2019-09-15 10:54 ` Neftin, Sasha
2019-09-14 1:07 ` Brown, Aaron F
2019-09-18 19:29 ` David Arcari
2019-09-18 20:29 ` Alexander Duyck
2019-09-19 5:48 ` Neftin, Sasha
2019-09-19 11:49 ` David Arcari
2019-09-19 12:56 ` Neftin, Sasha [this message]
2019-09-24 10:25 ` Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bedf2d12-9a0e-2633-2d02-27c35d03fc35@intel.com \
--to=sasha.neftin@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox