From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9340EC4332F for ; Thu, 3 Nov 2022 15:50:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 186C8404B0; Thu, 3 Nov 2022 15:50:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 186C8404B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1667490644; bh=RJUhN50LybjNigJbDUrz3FSnfgOENdWn3Gdvok1F2sM=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=jz2hJg+2uFUeXnDhcHLYi509PaCtvkzwYPTfhAAn78CkWrUr6G037qAMaC1tx5kkd 90Uxz4gN5EVYT+X5zYDQFbhxQVXDvazovTIK0iHDuG9TFgQINRbPhzhVMDYFkdeaUA ySsoDWjYkkSf4PRRJKYhGEXz4kAf432f22e5tIN+q9D9SflAFefNmEFsKCh/aAU1oM 6/ct+ZIRSJdJRcljAe0trDHM63umvwle4YHF9TVIcVmmhKNWy0zKqvdB+gKWPmG0CQ S/djqCKDXHEGzY9vI/8koCd+F2X4xtnnkilLoEoOSopOY+ej+XI9uNrr1xEa/3zLvM mXlvJObiStuNA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PZtTuWVve0wm; Thu, 3 Nov 2022 15:50:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 2816C404BF; Thu, 3 Nov 2022 15:50:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2816C404BF Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id BDE601BF2C4 for ; Thu, 3 Nov 2022 12:03:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9195360FD4 for ; Thu, 3 Nov 2022 12:03:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9195360FD4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sY1WV7ngLFVW for ; Thu, 3 Nov 2022 12:03:45 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 347E760FD2 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by smtp3.osuosl.org (Postfix) with ESMTPS id 347E760FD2 for ; Thu, 3 Nov 2022 12:03:45 +0000 (UTC) Received: by mail-wr1-f47.google.com with SMTP id cl5so2404423wrb.9 for ; Thu, 03 Nov 2022 05:03:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=frMmRWbz+CrWSwXHd1wJhRWogqGhZzQQP8lyso7wOSg=; b=XfxvFvcGJmX/OZvHWs+N/LMR/jjHWoEgkF4mOSV+7PmFDr4QUIqzAlwGWuACCwQz7H tyzt3/3zLnIrwSdUHuHSyrl4UEa87bC1/Mrz90T18Zl7G4fjI6yWlx2OlQCGqtBYxOGM Cyp3Dm6R5unMa+ypDb9mDMtBdLm+Px2183+Tphilj6irbtMG3kMx1Hwr3CWUHav0Yh18 GcLhmlsq9aYmRQnIVDs/tl0PhZn/UEMPG9ZajHjZQGvKsNvHUor6thX5xj7+8m7RFy7J m/IQX+zh3yTMkCh7AQB+IQMqfPK6PlZgqwj1l3i29ovXcf5hOf+Xmf4bTth5xxJIYCiI Oj6g== X-Gm-Message-State: ACrzQf3pWLzrlE/rcFE4sk4FaEmJdEb8V/by45w+U98iqDHaplGxzJqU 9cVV1NLBCs0DWk4I5aothos= X-Google-Smtp-Source: AMsMyM7mOpiAGdP3bMUTH4qm2eG3uGGD+AF28LOaryDBJl0zkEaKdVJwqta2ulDwD21Y5KVQVqxwyw== X-Received: by 2002:a5d:62cd:0:b0:236:6ea0:a609 with SMTP id o13-20020a5d62cd000000b002366ea0a609mr17472410wrv.508.1667477023312; Thu, 03 Nov 2022 05:03:43 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id c4-20020a05600c0a4400b003cf894c05e4sm3778568wmq.22.2022.11.03.05.03.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 05:03:42 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 13:03:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Content-Language: en-US To: Jakub Kicinski References: <20221031114456.10482-1-jirislaby@kernel.org> <20221102204110.26a6f021@kernel.org> From: Jiri Slaby In-Reply-To: <20221102204110.26a6f021@kernel.org> X-Mailman-Approved-At: Thu, 03 Nov 2022 15:50:41 +0000 Subject: Re: [Intel-wired-lan] [PATCH] i40e (gcc13): synchronize allocate/free functions return type & values X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , intel-wired-lan@lists.osuosl.org, Paolo Abeni , Martin Liska , "David S. Miller" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 03. 11. 22, 4:41, Jakub Kicinski wrote: > On Mon, 31 Oct 2022 12:44:56 +0100 Jiri Slaby (SUSE) wrote: >> I.e. the type of their return value in the definition is int, while the >> declaration spell enum i40e_status. Synchronize the definitions to the >> latter. >> >> And make sure proper values are returned. I.e. I40E_SUCCESS and not 0, >> I40E_ERR_NO_MEMORY and not -ENOMEM. > > Let's go the opposite way, towards using standard errno. This is propagated several layers up throughout the whole i40e driver. It would be a mass change which I'd rather leave up to the driver maintainers -- I don't even have the HW to test. thanks, -- js _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan