From: "naamax.meir" <naamax.meir@linux.intel.com>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
intel-wired-lan@osuosl.org, vinicius.gomes@intel.com
Cc: anthony.l.nguyen@intel.com, tee.min.tan@linux.intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 1/3] igc: remove I226 Qbv BaseTime restriction
Date: Sun, 1 Jan 2023 13:31:17 +0200 [thread overview]
Message-ID: <c4127a7a-da23-41f9-6e3b-e2a15794975d@linux.intel.com> (raw)
In-Reply-To: <20221214162909.22856-2-muhammad.husaini.zulkifli@intel.com>
On 12/14/2022 18:29, Muhammad Husaini Zulkifli wrote:
> Remove the Qbv BaseTime restriction for I226 so that the BaseTime can be
> scheduled to the future time. A new register bit of Tx Qav Control
> (Bit-7: FutScdDis) was introduced to allow I226 scheduling future time as
> Qbv BaseTime and not having the Tx hang timeout issue.
>
> Besides, according to datasheet section 7.5.2.9.3.3, FutScdDis bit has to
> be configured first before the cycle time and base time.
>
> Indeed the FutScdDis bit is only active on re-configuration, thus we have
> to set the BASET_L to zero and then only set it to the desired value.
>
> Please also note that the Qbv configuration flow is moved around based on
> the Qbv programming guideline that is documented in the latest datasheet.
>
> Co-developed-by: Tan Tee Min <tee.min.tan@linux.intel.com>
> Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_base.c | 29 +++++++++++++
> drivers/net/ethernet/intel/igc/igc_base.h | 2 +
> drivers/net/ethernet/intel/igc/igc_defines.h | 1 +
> drivers/net/ethernet/intel/igc/igc_main.c | 5 ++-
> drivers/net/ethernet/intel/igc/igc_tsn.c | 44 +++++++++++++-------
> 5 files changed, 65 insertions(+), 16 deletions(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-01 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 16:29 [Intel-wired-lan] [PATCH net-next v2 0/3] igc: Qbv Feature Improvement for I226 Muhammad Husaini Zulkifli
2022-12-14 16:29 ` [Intel-wired-lan] [PATCH net-next v2 1/3] igc: remove I226 Qbv BaseTime restriction Muhammad Husaini Zulkifli
2023-01-01 11:31 ` naamax.meir [this message]
2022-12-14 16:29 ` [Intel-wired-lan] [PATCH net-next v2 2/3] igc: enable Qbv configuration for 2nd GCL Muhammad Husaini Zulkifli
2023-01-01 11:33 ` naamax.meir
2022-12-14 16:29 ` [Intel-wired-lan] [PATCH net-next v2 3/3] igc: Remove reset adapter task for i226 during disable tsn config Muhammad Husaini Zulkifli
2023-01-01 11:35 ` naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4127a7a-da23-41f9-6e3b-e2a15794975d@linux.intel.com \
--to=naamax.meir@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=tee.min.tan@linux.intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox