From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2E6EC10DC1 for ; Mon, 4 Dec 2023 22:25:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5A1FC81EBB; Mon, 4 Dec 2023 22:25:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5A1FC81EBB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701728758; bh=MFrAithHhmrFnaD5oH8S5GmMyREqRYuNyaUhbQ2tX1U=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=cHad18sUp4zWwosA1L5+6PsLqzV+FpJ+BgnAd8vJ+GB+aLNUKoJIeyyEhZzikqzsD 5E/t2sAJlCt/phE5GdJlnt7Pwuhqnn0lfJoPeJyiJ4LVOdc75rI0MDwn2HCPecktl6 2AwidB2q2u82ZLkg9a1NK02XksMYucibGQObkNzWxLn73RuJOopht6xSueQovXwG4Y 3r9g7kIsVCNnRYwrgOFeQwS+1koqfHAqL+lEezO3pISo2E/b0Z4xJ6rs8gtbc26sax +YANqq/djQG6QMs98cXNB6VChVH8bFehopyVtCglt41enORduj3V5cIjciA5zouLoC 6yAtc199hwe4A== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JLM8ZtFvRdaB; Mon, 4 Dec 2023 22:25:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 353CF81E21; Mon, 4 Dec 2023 22:25:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 353CF81E21 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0AF681BF303 for ; Mon, 4 Dec 2023 22:25:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D6F7281E21 for ; Mon, 4 Dec 2023 22:25:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D6F7281E21 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3gDC4DPGuaw6 for ; Mon, 4 Dec 2023 22:25:55 +0000 (UTC) Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by smtp1.osuosl.org (Postfix) with ESMTPS id 10FE381CE1 for ; Mon, 4 Dec 2023 22:25:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 10FE381CE1 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rAHNr-0000000FIS0-1ZJ1; Mon, 04 Dec 2023 23:25:47 +0100 Message-ID: From: Johannes Berg To: Jakub Kicinski Date: Mon, 04 Dec 2023 23:25:46 +0100 In-Reply-To: <20231204142217.176ed99f@kernel.org> References: <20231204200710.40c291e60cea.I2deb5804ef1739a2af307283d320ef7d82456494@changeid> <20231204200038.GA9330@merlins.org> <20231204203622.GB9330@merlins.org> <24577c9b8b4d398fe34bd756354c33b80cf67720.camel@sipsolutions.net> <20231204205439.GA32680@merlins.org> <20231204212849.GA25864@merlins.org> <69c0fa67c2b0930f72e99c19c72fc706627989af.camel@sipsolutions.net> <20231204142217.176ed99f@kernel.org> User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=bK+byPxsZuHaPYRYQodVTgZI8myAPdyvRrsGFJ0hqUs=; t=1701728755; x=1702938355; b=h77tw5yGtJ+ckwcUN/AInD96+wfpUB/DO++99LsUwTxEf5L 2HNxyxlo4gfy6vUS+Y1qzeY/4tTiBD+QXJh7taDtt+DKQEAAedA1702wryT53y/yfiAjsJNcCycQ9 2Z3QFF2Rox875X5t9N2vU3bLoIRXhhZk42seaE/mMxm0rf6603BlzTLv11scVp2uDVlbAPow0Ac0n g6LdupZ+DFpuE73ff322dd2AitOSw0/9SU3CatVvk/bP6boRMkOESFDBPle7NLcMAC/smTkZxzhWr rVcbIK+2u1Ver/LI024nL5VqD14+LO550PsF6XR5eT+Rfl9OEc7efBIB/tqshgKA==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=h77tw5yG Subject: Re: [Intel-wired-lan] [RFC PATCH] net: ethtool: do runtime PM outside RTNL X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Marc MERLIN , Jesse Brandeburg , Tony Nguyen , intel-wired-lan@lists.osuosl.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 2023-12-04 at 14:22 -0800, Jakub Kicinski wrote: > On Mon, 04 Dec 2023 22:32:25 +0100 Johannes Berg wrote: > > Well, I was hoping that > > > > (a) ethtool folks / Jakub would comment if this makes sense, but I > > don't see a good reason to do things the other way around (other > > than "code is simpler"); and > > My opinion on RPM is pretty uneducated. But taking rtnl_lock to resume > strikes me as shortsighted. RPM functionality should be fairly > self-contained, and deserving of a separate lock. > Or at the very least having looked at the igc RPM code in the past, > I'm a bit cautious about bending the core to fit it, as it is hardly > a model... I could agree with that. The reason it seems to do that is that it invokes some other ifup/down related code in suspend/resume... On the other hand it also seems a bit odd to do something as unrelated to networking as runtime PM (which you can also trigger through various other paths such as sysfs) under RTNL, holding RTNL for longer than seems necessary, and creating more contention on it? johannes _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan