Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] 5.10.0 kernel regression for 2.5Gbps link negotiation?
Date: Fri, 18 Dec 2020 15:07:06 -0800	[thread overview]
Message-ID: <c54c8f2c-a295-c691-466e-07ae8f41b0ac@candelatech.com> (raw)
In-Reply-To: <3bcba0ca-8f3b-8428-861a-86aaff1688b6@molgen.mpg.de>

On 12/18/20 11:43 AM, Paul Menzel wrote:
> Dear Todd,
> 
> 
> Am 18.12.20 um 20:27 schrieb Fujinaka, Todd:
>> Yes, and I'm plugging the hole in the README right now. Here's the proposed text:
>>
>> Advertisements for 2.5G and 5G on the x550 were turned off by default due to
>> interoperability issues with certain switches. To turn them back on, use
>>
>> ethtool -s <ethX> advertise N
>>
>> where N is a combination of the following.
>>
>> 100baseTFull??? 0x008
>> 1000baseTFull?? 0x020
>> 2500baseTFull?? 0x800000000000
>> 5000baseTFull?? 0x1000000000000
>> 10000baseTFull? 0x1000
>>
>> For example, to turn on all modes:
>> ethtool -s <ethX> advertise 0x1800000001028
>>
>> For more details please see the ethtool man page.
> 
> What commit introduced this regression. Please bear in mind, that this contradicts Linux? no-regression policy, and the commit should therefore be reverted as 
> soon as possible.

Looks like it is at the end of this patch, though the description doesn't
mention changing defaults:

Commit a296d665eae1e8ec6445683bfb999c884058426a
Author: Radoslaw Tyl <radoslawx.tyl@intel.com>
Date:   Fri Jun 26 15:28:14 2020 +0200

     ixgbe: Add ethtool support to enable 2.5 and 5.0 Gbps support

     Added full support for new version Ethtool API. New API allow use
     2500Gbase-T and 5000base-T supported and advertised link speed modes.

     Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
     Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
     Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

Thanks,
Ben

> 
> 
> Kind regards,
> 
> Paul
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2020-12-18 23:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 18:08 [Intel-wired-lan] 5.10.0 kernel regression for 2.5Gbps link negotiation? Ben Greear
2020-12-18 19:27 ` Fujinaka, Todd
2020-12-18 19:41   ` Ben Greear
2020-12-18 19:43   ` Paul Menzel
2020-12-18 23:07     ` Ben Greear [this message]
2020-12-18 23:19       ` Paul Menzel
2020-12-19  0:09         ` Fujinaka, Todd
2020-12-19  0:47           ` Ben Greear
2020-12-19 16:19             ` Fujinaka, Todd
2020-12-19 16:48               ` Ben Greear
2020-12-21 15:20                 ` Fujinaka, Todd
2020-12-21 15:52                   ` Ben Greear
2020-12-21 15:58                     ` Fujinaka, Todd
2020-12-21 16:04                       ` Ben Greear
2020-12-22  8:59                     ` Greg KH
2020-12-21 15:09               ` [Intel-wired-lan] ixgbe: " Paul Menzel
2020-12-21 15:16                 ` Fujinaka, Todd
2020-12-21 15:31                   ` Hisashi T Fujinaka
2020-12-19  7:54           ` Paul Menzel
2020-12-19 16:07             ` Fujinaka, Todd
2020-12-19 20:59               ` Linus Torvalds
2020-12-21 15:12                 ` Fujinaka, Todd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c54c8f2c-a295-c691-466e-07ae8f41b0ac@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox