Re: [Intel-wired-lan] [External] : Re: [PATCH net-next] ice: fix comment typo and correct module format string

[ALOK TIWARI <alok.a.tiwari@oracle.com>]

On 11/9/2025 8:11 PM, Paul Menzel wrote:
> Dear Alok,
> 
> 
> Thank you for your patch.
> 
> Am 07.11.25 um 13:39 schrieb Alok Tiwari:
>> - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" -> "if")
>>
>> - Correct the NVM erase error message format string from "0x02%x" to
>>    "0x%02x" so the module value is printed correctly.
> 
> Listing changes in a commit message is a good indicator to split it up, 
> even it’s formal changes.
> 

Thanks You, Paul
I will ensure that future submissions split each logical change
into separate patches, including formal or cosmetic fixes.

>> - * returns true is there is a fragment packet for this ptype
>> + * returns true if there is a fragment packet for this ptype
>>    */
>>   bool ice_fdir_has_frag(enum ice_fltr_ptype flow)
>>   {
>> diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c b/drivers/ 
>> net/ethernet/intel/ice/ice_fw_update.c
>> index d86db081579f..973a13d3d92a 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_fw_update.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c
>> @@ -534,7 +534,7 @@ ice_erase_nvm_module(struct ice_pf *pf, u16 
>> module, const char *component,
>>       }
>>       if (completion_retval) {
>> -        dev_err(dev, "Firmware failed to erase %s (module 0x02%x), 
>> aq_err %s\n",
>> +        dev_err(dev, "Firmware failed to erase %s (module 0x%02x), 
>> aq_err %s\n",
>>               component, module,
>>               libie_aq_str((enum libie_aq_err)completion_retval));
>>           NL_SET_ERR_MSG_MOD(extack, "Firmware failed to erase flash");
> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul


Thanks,
Alok