[Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct module format string

[Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct module format string

[Alok Tiwari]

- Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" -> "if")

- Correct the NVM erase error message format string from "0x02%x" to
  "0x%02x" so the module value is printed correctly.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 drivers/net/ethernet/intel/ice/ice_fdir.c      | 2 +-
 drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c
index 26b357c0ae15..ec73088ef37b 100644
--- a/drivers/net/ethernet/intel/ice/ice_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
@@ -1121,7 +1121,7 @@ ice_fdir_get_gen_prgm_pkt(struct ice_hw *hw, struct ice_fdir_fltr *input,
  * ice_fdir_has_frag - does flow type have 2 ptypes
  * @flow: flow ptype
  *
- * returns true is there is a fragment packet for this ptype
+ * returns true if there is a fragment packet for this ptype
  */
 bool ice_fdir_has_frag(enum ice_fltr_ptype flow)
 {
diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c b/drivers/net/ethernet/intel/ice/ice_fw_update.c
index d86db081579f..973a13d3d92a 100644
--- a/drivers/net/ethernet/intel/ice/ice_fw_update.c
+++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c
@@ -534,7 +534,7 @@ ice_erase_nvm_module(struct ice_pf *pf, u16 module, const char *component,
 	}
 
 	if (completion_retval) {
-		dev_err(dev, "Firmware failed to erase %s (module 0x02%x), aq_err %s\n",
+		dev_err(dev, "Firmware failed to erase %s (module 0x%02x), aq_err %s\n",
 			component, module,
 			libie_aq_str((enum libie_aq_err)completion_retval));
 		NL_SET_ERR_MSG_MOD(extack, "Firmware failed to erase flash");
-- 
2.50.1

Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct module format string

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Alok Tiwari
> Sent: Friday, November 7, 2025 1:40 PM
> To: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Lobakin,
> Aleksander <aleksander.lobakin@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; andrew+netdev@lunn.ch; kuba@kernel.org;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; intel-
> wired-lan@lists.osuosl.org; netdev@vger.kernel.org
> Cc: alok.a.tiwarilinux@gmail.com; alok.a.tiwari@oracle.com
> Subject: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and
> correct module format string
> 
> - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" ->
> "if")
> 
> - Correct the NVM erase error message format string from "0x02%x" to
>   "0x%02x" so the module value is printed correctly.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_fdir.c      | 2 +-
>  drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_fdir.c
> index 26b357c0ae15..ec73088ef37b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> @@ -1121,7 +1121,7 @@ ice_fdir_get_gen_prgm_pkt(struct ice_hw *hw,
> struct ice_fdir_fltr *input,
>   * ice_fdir_has_frag - does flow type have 2 ptypes
>   * @flow: flow ptype
>   *
> - * returns true is there is a fragment packet for this ptype
> + * returns true if there is a fragment packet for this ptype
>   */
>  bool ice_fdir_has_frag(enum ice_fltr_ptype flow)  { diff --git
> a/drivers/net/ethernet/intel/ice/ice_fw_update.c
> b/drivers/net/ethernet/intel/ice/ice_fw_update.c
> index d86db081579f..973a13d3d92a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fw_update.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c
> @@ -534,7 +534,7 @@ ice_erase_nvm_module(struct ice_pf *pf, u16
> module, const char *component,
>  	}
> 
>  	if (completion_retval) {
> -		dev_err(dev, "Firmware failed to erase %s (module
> 0x02%x), aq_err %s\n",
> +		dev_err(dev, "Firmware failed to erase %s (module
> 0x%02x), aq_err
> +%s\n",
>  			component, module,
>  			libie_aq_str((enum
> libie_aq_err)completion_retval));
>  		NL_SET_ERR_MSG_MOD(extack, "Firmware failed to erase
> flash");
> --
> 2.50.1

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct module format string

[Keller, Jacob E]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Loktionov, Aleksandr
> Sent: Friday, November 7, 2025 5:16 AM
> To: Alok Tiwari <alok.a.tiwari@oracle.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>; Lobakin, Aleksander
> <aleksander.lobakin@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; andrew+netdev@lunn.ch; kuba@kernel.org;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; intel-
> wired-lan@lists.osuosl.org; netdev@vger.kernel.org
> Cc: alok.a.tiwarilinux@gmail.com
> Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct
> module format string
> 
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> > Of Alok Tiwari
> > Sent: Friday, November 7, 2025 1:40 PM
> > To: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Lobakin,
> > Aleksander <aleksander.lobakin@intel.com>; Nguyen, Anthony L
> > <anthony.l.nguyen@intel.com>; andrew+netdev@lunn.ch; kuba@kernel.org;
> > davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; intel-
> > wired-lan@lists.osuosl.org; netdev@vger.kernel.org
> > Cc: alok.a.tiwarilinux@gmail.com; alok.a.tiwari@oracle.com
> > Subject: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and
> > correct module format string
> >
> > - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" ->
> > "if")
> >
> > - Correct the NVM erase error message format string from "0x02%x" to
> >   "0x%02x" so the module value is printed correctly.
> >
> > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> > ---
> >  drivers/net/ethernet/intel/ice/ice_fdir.c      | 2 +-
> >  drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c
> > b/drivers/net/ethernet/intel/ice/ice_fdir.c
> > index 26b357c0ae15..ec73088ef37b 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> > @@ -1121,7 +1121,7 @@ ice_fdir_get_gen_prgm_pkt(struct ice_hw *hw,
> > struct ice_fdir_fltr *input,
> >   * ice_fdir_has_frag - does flow type have 2 ptypes
> >   * @flow: flow ptype
> >   *
> > - * returns true is there is a fragment packet for this ptype
> > + * returns true if there is a fragment packet for this ptype

I know this is a simple typo fix and am fine accepting the patch as-is, but you could also clean this kdoc error up by using "Returns:" here to avoid a warning from the kernel-doc script.

Thanks,
Jake

Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct module format string

[Paul Menzel]

Dear Alok,


Thank you for your patch.

Am 07.11.25 um 13:39 schrieb Alok Tiwari:
> - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" -> "if")
> 
> - Correct the NVM erase error message format string from "0x02%x" to
>    "0x%02x" so the module value is printed correctly.

Listing changes in a commit message is a good indicator to split it up, 
even it’s formal changes.

> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_fdir.c      | 2 +-
>   drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c
> index 26b357c0ae15..ec73088ef37b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> @@ -1121,7 +1121,7 @@ ice_fdir_get_gen_prgm_pkt(struct ice_hw *hw, struct ice_fdir_fltr *input,
>    * ice_fdir_has_frag - does flow type have 2 ptypes
>    * @flow: flow ptype
>    *
> - * returns true is there is a fragment packet for this ptype
> + * returns true if there is a fragment packet for this ptype
>    */
>   bool ice_fdir_has_frag(enum ice_fltr_ptype flow)
>   {
> diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c b/drivers/net/ethernet/intel/ice/ice_fw_update.c
> index d86db081579f..973a13d3d92a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fw_update.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c
> @@ -534,7 +534,7 @@ ice_erase_nvm_module(struct ice_pf *pf, u16 module, const char *component,
>   	}
>   
>   	if (completion_retval) {
> -		dev_err(dev, "Firmware failed to erase %s (module 0x02%x), aq_err %s\n",
> +		dev_err(dev, "Firmware failed to erase %s (module 0x%02x), aq_err %s\n",
>   			component, module,
>   			libie_aq_str((enum libie_aq_err)completion_retval));
>   		NL_SET_ERR_MSG_MOD(extack, "Firmware failed to erase flash");

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

Re: [Intel-wired-lan] [External] : Re: [PATCH net-next] ice: fix comment typo and correct module format string

[ALOK TIWARI]

On 11/9/2025 8:11 PM, Paul Menzel wrote:
> Dear Alok,
> 
> 
> Thank you for your patch.
> 
> Am 07.11.25 um 13:39 schrieb Alok Tiwari:
>> - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" -> "if")
>>
>> - Correct the NVM erase error message format string from "0x02%x" to
>>    "0x%02x" so the module value is printed correctly.
> 
> Listing changes in a commit message is a good indicator to split it up, 
> even it’s formal changes.
> 

Thanks You, Paul
I will ensure that future submissions split each logical change
into separate patches, including formal or cosmetic fixes.

>> - * returns true is there is a fragment packet for this ptype
>> + * returns true if there is a fragment packet for this ptype
>>    */
>>   bool ice_fdir_has_frag(enum ice_fltr_ptype flow)
>>   {
>> diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c b/drivers/ 
>> net/ethernet/intel/ice/ice_fw_update.c
>> index d86db081579f..973a13d3d92a 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_fw_update.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c
>> @@ -534,7 +534,7 @@ ice_erase_nvm_module(struct ice_pf *pf, u16 
>> module, const char *component,
>>       }
>>       if (completion_retval) {
>> -        dev_err(dev, "Firmware failed to erase %s (module 0x02%x), 
>> aq_err %s\n",
>> +        dev_err(dev, "Firmware failed to erase %s (module 0x%02x), 
>> aq_err %s\n",
>>               component, module,
>>               libie_aq_str((enum libie_aq_err)completion_retval));
>>           NL_SET_ERR_MSG_MOD(extack, "Firmware failed to erase flash");
> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul


Thanks,
Alok