From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v3] ice: Manage act flags for switchdev offloads
Date: Wed, 22 Sep 2021 21:38:46 +0000 [thread overview]
Message-ID: <ca10f3feb675a8cbf59dee32bc3f1de3fe4e5a49.camel@intel.com> (raw)
In-Reply-To: <20210922084332.159306-1-wojciech.drewek@intel.com>
On Wed, 2021-09-22 at 10:43 +0200, Wojciech Drewek wrote:
> Currently it is not possible to set/unset lb_en and lan_en flags
> for advanced rules during their creation. Both flags are enabled
> by default. In case of switchdev offloads for egress traffic we
> need lb_en to be disabled. Because of that, we work around it by
> updating the rule immediately after its creation.
>
> This change allows us to set/unset those flags right away and it
> gets rid of old workaround as well. Using ice_adv_rule_flags_info
> structure we can pass info about flags we want to be set for
> a given advanced rule. Flags are stored in flags_info.act.
> Values from act would be used only if act_valid was set to true,
> otherwise default values would be used.
>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> ---
Can you include changelogs so that reviewing between versions is
easier?
Thanks,
Tony
> drivers/net/ethernet/intel/ice/ice_fltr.c | 127 ------------------
> --
> drivers/net/ethernet/intel/ice/ice_fltr.h | 4 -
> drivers/net/ethernet/intel/ice/ice_switch.c | 9 +-
> drivers/net/ethernet/intel/ice/ice_switch.h | 11 ++
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 8 +-
> 5 files changed, 21 insertions(+), 138 deletions(-)
prev parent reply other threads:[~2021-09-22 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 8:43 [Intel-wired-lan] [PATCH net-next v3] ice: Manage act flags for switchdev offloads Wojciech Drewek
2021-09-22 21:38 ` Nguyen, Anthony L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca10f3feb675a8cbf59dee32bc3f1de3fe4e5a49.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox