From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Karen Ostrowska <karen.ostrowska@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Brett Creeley <brett.creeley@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v1] ice: Fix disabling Rx VLAN filtering with port VLAN enabled
Date: Fri, 13 Jan 2023 13:59:03 -0800 [thread overview]
Message-ID: <ca88f959-e658-fe9c-6011-1d38d50a61ef@intel.com> (raw)
In-Reply-To: <20230112145434.770847-1-karen.ostrowska@intel.com>
On 1/12/2023 6:54 AM, Karen Ostrowska wrote:
> From: Brett Creeley <brett.creeley@intel.com>
>
> If the user turns on the vf-true-promiscuous-support flag, then Rx VLAN
> filtering will be disabled if the VF requests to enable promiscuous
> mode. When the VF is in a port VLAN, this is the incorrect behavior
> because it will allow the VF to receive traffic outside of its port VLAN
> domain. Fortunately this only resulted in the VF(s) receiving broadcast
> traffic outside of the VLAN domain because all of the VLAN promiscuous
> rules are based on the port VLAN ID. Fix this by setting the
> .disable_rx_filtering VLAN op to a no-op when a port VLAN is enabled on
> the VF.
>
> Also, make sure to make this fix for both Single VLAN Mode and Double
> VLAN Mode enabled devices.
>
> Fixes: c31af68a1b94 ("ice: Add outer_vlan_ops and VSI specific VLAN ops
> implementations")
nit: Please don't break up the Fixes tag to multiple lines.
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1>
("<title line>")' - ie: 'Fixes: d07633fca9d5 ("ice: Fix disabling Rx
VLAN filtering with port VLAN enabled")'
#22:
Fixes: c31af68a1b94 ("ice: Add outer_vlan_ops and VSI specific VLAN ops
> Signed-off-by: Brett Creeley <brett.creeley@intel.com>
> Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-13 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 14:54 [Intel-wired-lan] [PATCH net v1] ice: Fix disabling Rx VLAN filtering with port VLAN enabled Karen Ostrowska
2023-01-13 14:48 ` Michal Swiatkowski
2023-01-13 21:59 ` Tony Nguyen [this message]
2023-01-26 14:48 ` Szlosek, Marek
-- strict thread matches above, loose matches on Subject: below --
2023-01-16 12:34 Karen Ostrowska
2023-01-26 14:31 ` Szlosek, Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca88f959-e658-fe9c-6011-1d38d50a61ef@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=brett.creeley@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karen.ostrowska@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox