From: "Neftin, Sasha" <sasha.neftin@intel.com>
To: <prasad@arista.com>, <intel-wired-lan@lists.osuosl.org>,
"Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
"Fuxbrumer, Devora" <devora.fuxbrumer@intel.com>,
naamax.meir <naamax.meir@linux.intel.com>,
"Avivi, Amir" <amir.avivi@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Cc: gilligan@arista.com
Subject: Re: [Intel-wired-lan] [PATCH] intel-wired-lan: igc: set TP bit in ethtool_link_ksettings.supported field
Date: Fri, 2 Jun 2023 10:34:05 +0300 [thread overview]
Message-ID: <cbb5bf34-5082-13ec-45b8-590268279bae@intel.com> (raw)
In-Reply-To: <20230601185353.17012-1-prasad@arista.com>
On 6/1/2023 21:53, prasad@arista.com wrote:
> From: Prasad Koya <prasad@arista.com>
>
> if the physical media is twisted pair copper, set the TP bit in the
> 'supported' field
>
> Signed-off-by: Prasad Koya <prasad@arista.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 8cc077b712ad..7d197fa80d5d 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1707,6 +1707,8 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
> /* twisted pair */
> cmd->base.port = PORT_TP;
> cmd->base.phy_address = hw->phy.addr;
> + if (hw->phy.media_type == igc_media_type_copper)
Thank you Prasad. i225/6 parts supported only copper media type. We can
drop the "if" condition.
> + ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
Do you want to see: "Supported ports: [ TP ]"? That's right.
>
> /* advertising link modes */
> if (hw->phy.autoneg_advertised & ADVERTISE_10_HALF)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-06-02 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 18:53 [Intel-wired-lan] [PATCH] intel-wired-lan: igc: set TP bit in ethtool_link_ksettings.supported field prasad
2023-06-02 7:34 ` Neftin, Sasha [this message]
2023-06-02 7:49 ` Prasad Koya
2023-06-03 6:05 ` Prasad Koya
2023-06-04 7:19 ` Neftin, Sasha
2023-06-05 3:17 ` Prasad Koya
-- strict thread matches above, loose matches on Subject: below --
2023-06-02 8:23 prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbb5bf34-5082-13ec-45b8-590268279bae@intel.com \
--to=sasha.neftin@intel.com \
--cc=amir.avivi@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=devora.fuxbrumer@intel.com \
--cc=dima.ruinskiy@intel.com \
--cc=gilligan@arista.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=naamax.meir@linux.intel.com \
--cc=prasad@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox