Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix NULL pointer access during resume

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 2/22/2024 2:19 PM, Keller, Jacob E wrote:

>> -----Original Message-----
>> From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>

...

>>> NOTE:
>>> Requires Amritha's patch:
>>> https://patchwork.ozlabs.org/project/intel-wired-
>> lan/patch/170785373072.3325.9129916579186572531.stgit@anambiarhost.jf.
>> intel.com/
>>> to be applied before this will pass testing cleanly.
>>
>> I think this may be the other way around? It looks to be clean for
>> netdev (doesn't have Amritha's patch), but it's not applying to
>> net-queue (has Amritha's patch).
>>
>>   > base-commit: 23f9c2c066e7e5052406fb8f04a115d3d0260b22
>>
>> Base commit also seems to be a netdev commit.
>>
>> Since Amritha's patch is pending to netdev [1], I think we need a
>> version that will apply with Amritha's changes.
>>
>> Thanks,
>> Tony
>>
>>
>> [1]
>> https://lore.kernel.org/netdev/20240220214444.1039759-7-
>> anthony.l.nguyen@intel.com/
> 
> I think he means that the tests won't pass without Amritha's patch because we'll hit the ASSERT_RTNL in the suspend flow otherwise.

Got it. Anyways, this doesn't apply to net-queue, could we rebase or 
base it off of that tree?

Thanks,
Tony

> Thanks,
> Jake