From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Dave Ertman <david.m.ertman@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: netdev@vger.kernel.org, bcreeley@amd.com,
daniel.machon@microchip.com, simon.horman@corigine.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 05/10] ice: process events created by lag netdev event handler
Date: Fri, 16 Jun 2023 13:47:58 -0700 [thread overview]
Message-ID: <ce07a11a-20eb-dcb9-22e8-489333a0799c@intel.com> (raw)
In-Reply-To: <20230615162932.762756-6-david.m.ertman@intel.com>
On 6/15/2023 9:29 AM, Dave Ertman wrote:
...
> +static void
> +ice_lag_monitor_rdma(struct ice_lag *lag, void *ptr)
> +{
> + struct netdev_notifier_changeupper_info *info;
> + struct net_device *netdev;
> + struct ice_pf *pf;
> +
> + info = ptr;
> + netdev = netdev_notifier_info_to_dev(ptr);
> +
> + if (netdev != lag->netdev)
> return;
> - }
>
> if (info->linking)
> - ice_lag_link(lag, info);
> + ice_clear_rdma_cap(pf);
> else
> - ice_lag_unlink(lag, info);
> -
> - ice_display_lag_info(lag);
> + ice_set_rdma_cap(pf);
pf isn't being assigned. Clang reports:
+../drivers/net/ethernet/intel/ice/ice_lag.c:657:22: warning: variable
'pf' is uninitialized when used here [-Wuninitialized]
+ ice_clear_rdma_cap(pf);
+ ^~
+../drivers/net/ethernet/intel/ice/ice_lag.c:648:19: note: initialize
the variable 'pf' to silence this warning
+ struct ice_pf *pf;
+ ^
+ = NULL
+1 warning generated.
> }
>
> /**
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-06-16 20:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 16:29 [Intel-wired-lan] [PATCH iwl-next v5 00/10] Implement support for SRIOV + LAG Dave Ertman
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 01/10] ice: Correctly initialize queue context values Dave Ertman
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 02/10] ice: Add driver support for firmware changes for LAG Dave Ertman
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 03/10] ice: changes to the interface with the HW and FW for SRIOV_VF+LAG Dave Ertman
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 04/10] ice: implement lag netdev event handler Dave Ertman
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 05/10] ice: process events created by " Dave Ertman
2023-06-16 20:47 ` Tony Nguyen [this message]
2023-06-20 16:07 ` Ertman, David M
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 06/10] ice: Flesh out implementation of support for SRIOV on bonded interface Dave Ertman
2023-06-16 20:56 ` Tony Nguyen
2023-06-20 16:07 ` Ertman, David M
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 07/10] ice: support non-standard teardown of bond interface Dave Ertman
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 08/10] ice: enforce interface eligibility and add messaging for SRIOV LAG Dave Ertman
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 09/10] ice: enforce no DCB config changing when in bond Dave Ertman
2023-06-15 16:29 ` [Intel-wired-lan] [PATCH iwl-next v5 10/10] ice: update reset path for SRIOV LAG support Dave Ertman
-- strict thread matches above, loose matches on Subject: below --
2023-06-20 18:34 [Intel-wired-lan] [PATCH iwl-next v5 00/10] Implement support for SRIOV + LAG Dave Ertman
2023-06-20 18:34 ` [Intel-wired-lan] [PATCH iwl-next v5 05/10] ice: process events created by lag netdev event handler Dave Ertman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce07a11a-20eb-dcb9-22e8-489333a0799c@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=bcreeley@amd.com \
--cc=daniel.machon@microchip.com \
--cc=david.m.ertman@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox