Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Szycik <marcin.szycik@linux.intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net] ice: disable stripping in default VSI ctx
Date: Mon, 30 May 2022 13:25:04 +0200	[thread overview]
Message-ID: <d3493e8f-27d0-5a11-173f-74907b5410ff@linux.intel.com> (raw)
In-Reply-To: <8fd71e27-7f9a-fab8-62c5-b16839b882f5@intel.com>



On 27-May-22 18:31, Tony Nguyen wrote:
> 
> 
> On 5/27/2022 4:51 AM, Marcin Szycik wrote:
> 
> This fixes commit doesn't exist in net, so it shouldn't be targeting net. It looks like the patch this is fixing is still on Intel Wired LAN [1]. Perhaps it would be better to squash it with that patch as a v2?

You're right, sorry I didn't notice this. I will send next version with net-next tag and a squash note.

>> From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>>
>> In case when driver is in eswitch mode, having VLAN stripping enabled
>> causes failure in communication. All VLAN configuration commands are
>> blocked, because of that VF driver can't disable VLAN stripping at
>> initialization. It leads to the situation when VLAN stripping on VF VSI
>> is on, but in kernel it is off.
>>
>> To prevent this, set VLAN stripping to disabled in VSI initialization.
>> It doesn't break other usecases, because it is set according to kernel
>> settings.
>>
>> Fixes: f09901aa554a ("ice: remove VLAN representor specific ops")
>> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> 
> [1] https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220425062756.14987-3-michal.swiatkowski at linux.intel.com/

      reply	other threads:[~2022-05-30 11:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 11:51 [Intel-wired-lan] [PATCH net] ice: disable stripping in default VSI ctx Marcin Szycik
2022-05-27 12:15 ` Paul Menzel
2022-05-27 13:01   ` Marcin Szycik
2022-05-27 13:11     ` Paul Menzel
2022-05-27 16:17       ` Marcin Szycik
2022-05-27 16:31 ` Tony Nguyen
2022-05-30 11:25   ` Marcin Szycik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3493e8f-27d0-5a11-173f-74907b5410ff@linux.intel.com \
    --to=marcin.szycik@linux.intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox