Re: [Intel-wired-lan] [PATCH v6 net-next 02/15] netlink: spec: add shaper YAML spec

[Paolo Abeni <pabeni@redhat.com>]

oops,

I unintentionally stripped the recipients list, in my previous reply. 
Re-adding all of them. I'm sorry for the duplicates.

On 9/5/24 03:03, Jakub Kicinski wrote:
> On Wed,  4 Sep 2024 15:53:34 +0200 Paolo Abeni wrote:
>> +      -
>> +        name: node
>> +        type: nest
>> +        nested-attributes: node-info
>> +        doc: |
>> +           Describes the node shaper for a @group operation.
>> +           Differently from @leaves and @shaper allow specifying
>> +           the shaper parent handle, too.
> 
> Parent handle is inside node scope? Why are leaves outside and parent
> inside? Both should be at the same scope, preferably main scope.

The group() op receives as arguments, in the main scope:

ifindex
node
leaves

'parent' is a nested attribute for 'node', exactly as 'handle'. We need 
to specify both to identify the 'node' itself (via the 'handle') and to 
specify where in the hierarchy the 'node' will be located (via the 
'parent'). Do I read correctly that you would prefer:

ifindex
node_handle
node_parent
leaves
?

I think the former is more clean/clear.

>> +      -
>> +        name: shaper
>> +        type: nest
>> +        nested-attributes: info
>> +        doc: |
>> +           Describes a single shaper for a @set operation.
> 
> Why does this level of nesting exist? With the exception of ifindex
> all attributes for SET are nested inside this..

Yep, we can drop the nesting level, I think. I used the nesting to be 
have a syntax similar to the with group() operation.

Thanks,

Paolo