From: Jacob Keller <jacob.e.keller@intel.com>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: Anthony Nguyen <anthony.l.nguyen@intel.com>,
Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next 03/13] ice: move vsi_type assignment from ice_vsi_alloc to ice_vsi_cfg
Date: Wed, 18 Jan 2023 12:50:48 -0800 [thread overview]
Message-ID: <d5bf3764-9e59-e0a1-84c7-99cc041d134f@intel.com> (raw)
In-Reply-To: <Y8eFkqSXDbTOAaL4@localhost.localdomain>
On 1/17/2023 9:37 PM, Michal Swiatkowski wrote:
> On Tue, Jan 17, 2023 at 11:20:43AM -0800, Jacob Keller wrote:
>> Not sure what you mean? make sure idx is valid? but a memset of vsi will
>> initialize that to 0 which will be "valid"?
>>
>> or do you want to like confirm that the vsi->idx points to the vsi in
>> the array with the right pointer?
>>
>
> Maybe I am missing something. I assume that ther can be only one VF
> control VSI on VF. If we set vf->ctrl_vsi_idx to the new value we will lost
> previous one without removing the vsi index from hw. In case of PF
> control VSI we have WARN_ON for this case:
> WARN_ON(pf->ctr_idx != ICE_NO_VSI)
>
> Shouldn't we have
> WARN_ON(vf->ctrl_idx != ICE_NO_VSI)
> to be sure that there is no more VF control VSIs on this VF?
>
> When VF control VSI is removed the vf->ctr_vsi_idx is set to ICE_NO_VSI,
> so it should work as expected.
>
> Probably this case never happen (calling ice_vsi_setup() for VF control
> VSI second time on the same VF), but if we have the security check for
> PF it will be nice to have the same check for VF.
>
Yea, I misunderstood what you meant and that you were referring to the
WARN_ON in the PF case. I've fixed the series to include that now! Will
be in v2.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-18 20:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 22:37 [Intel-wired-lan] [PATCH net-next 00/13] ice: various virtualization cleanups Jacob Keller
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 01/13] ice: fix function comment referring to ice_vsi_alloc Jacob Keller
2023-01-16 10:31 ` Michal Swiatkowski
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 02/13] ice: drop unnecessary VF parameter from several VSI functions Jacob Keller
2023-01-16 10:34 ` Michal Swiatkowski
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 03/13] ice: move vsi_type assignment from ice_vsi_alloc to ice_vsi_cfg Jacob Keller
2023-01-16 10:47 ` Michal Swiatkowski
2023-01-17 19:20 ` Jacob Keller
2023-01-18 5:37 ` Michal Swiatkowski
2023-01-18 20:50 ` Jacob Keller [this message]
2023-01-17 22:24 ` Jacob Keller
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 04/13] ice: add helper function for checking VSI VF requirement Jacob Keller
2023-01-16 10:56 ` Michal Swiatkowski
2023-01-17 19:23 ` Jacob Keller
2023-01-18 5:24 ` Michal Swiatkowski
2023-01-18 20:49 ` Jacob Keller
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 05/13] ice: Fix RDMA latency issue by allowing write-combining Jacob Keller
2023-01-14 0:37 ` kernel test robot
2023-01-14 1:58 ` kernel test robot
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 06/13] ice: move ice_vf_vsi_release into ice_vf_lib.c Jacob Keller
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 07/13] ice: Pull common tasks into ice_vf_post_vsi_rebuild Jacob Keller
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 08/13] ice: add a function to initialize vf entry Jacob Keller
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 09/13] ice: introduce ice_vf_init_host_cfg function Jacob Keller
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 10/13] ice: convert vf_ops .vsi_rebuild to .create_vsi Jacob Keller
2023-01-27 9:46 ` Szlosek, Marek
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 11/13] ice: introduce clear_reset_state operation Jacob Keller
2023-01-14 1:17 ` kernel test robot
2023-01-14 3:49 ` kernel test robot
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 12/13] ice: introduce .irq_close VF operation Jacob Keller
2023-01-13 22:37 ` [Intel-wired-lan] [PATCH net-next 13/13] ice: remove unnecessary virtchnl_ether_addr struct use Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5bf3764-9e59-e0a1-84c7-99cc041d134f@intel.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox