From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Marcin Szycik <marcin.szycik@linux.intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: Block switchdev mode when ADQ is acvite and vice versa
Date: Tue, 1 Aug 2023 14:06:25 +0200 [thread overview]
Message-ID: <ddbc01d5-34c9-eea6-2c8f-6c8758a92792@intel.com> (raw)
In-Reply-To: <20230801115235.67343-1-marcin.szycik@linux.intel.com>
On 8/1/23 13:52, Marcin Szycik wrote:
> ADQ and switchdev are not supported simultaneously. Enabling both at the
> same time can result in nullptr dereference.
>
> To prevent this, check if ADQ is active when changing devlink mode to
> switchdev mode, and check if switchdev is active when enabling ADQ.
>
> Fixes: fbc7b27af0f9 ("ice: enable ndo_setup_tc support for mqprio_qdisc")
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_eswitch.c | 5 +++++
> drivers/net/ethernet/intel/ice/ice_main.c | 6 ++++++
> 2 files changed, 11 insertions(+)
>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-08-01 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 11:52 [Intel-wired-lan] [PATCH iwl-net] ice: Block switchdev mode when ADQ is acvite and vice versa Marcin Szycik
2023-08-01 12:06 ` Przemek Kitszel [this message]
2023-08-03 13:11 ` Leon Romanovsky
2023-08-03 13:26 ` Jiri Pirko
2023-08-03 15:11 ` Marcin Szycik
2023-08-03 17:43 ` Jiri Pirko
2023-08-03 14:58 ` Marcin Szycik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddbc01d5-34c9-eea6-2c8f-6c8758a92792@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox