From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6119AC25B79 for ; Fri, 24 May 2024 20:43:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 11D3980AE7; Fri, 24 May 2024 20:43:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 2tx52Ft_ZbS3; Fri, 24 May 2024 20:43:46 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 77D5480B42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1716583426; bh=15N/xS+H4siig6BCvvwm2jZ6/Oo7wlwtUPvsJ/tzFz8=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=EWKgLmVrZMM7sgO0zvo5mtkkrw0bmBdkxPq+AxvXOXVLO1B72zNgsrfHiM4cI9Ib4 AQJh0I8rjrrnjAFL4eiKnJKfx1TvgEESfyYix9Xsc+NarmZDhSjfLlEFphqSkcnYxr pxnXtebRdJwuYmhA8uJtpAq9Y4Edl8B+oCIBr0zO3NuW5FdpnmsGogqFlvajd1RBAg kYFKRMSQuRlMYCjRnqg0OznMHZYBaxSPfzbKJtAFBFhA9kfswukaJmFQODNJ33vEco ZjJ/ckhNIZKQ2F8FfIsVpEjmnhbIMt9t2a71nbZRft2YfvxGR2riQNOjJa/VLLk5pg vmTn4+eh7ebzA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 77D5480B42; Fri, 24 May 2024 20:43:46 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 4D6481CFDEC for ; Fri, 24 May 2024 20:43:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 38266404D3 for ; Fri, 24 May 2024 20:43:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id rrhjBThkOqW7 for ; Fri, 24 May 2024 20:43:44 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=141.14.17.11; helo=mx3.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 067D940447 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 067D940447 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by smtp2.osuosl.org (Postfix) with ESMTPS id 067D940447 for ; Fri, 24 May 2024 20:43:42 +0000 (UTC) Received: from [192.168.0.3] (ip5f5af1fe.dynamic.kabel-deutschland.de [95.90.241.254]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 5A82861E646D0; Fri, 24 May 2024 22:43:12 +0200 (CEST) Message-ID: Date: Fri, 24 May 2024 22:43:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Anil Samal References: <20240524135255.3607422-1-anil.samal@intel.com> <20240524135255.3607422-2-anil.samal@intel.com> Content-Language: en-US From: Paul Menzel In-Reply-To: <20240524135255.3607422-2-anil.samal@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ice: Extend Sideband Queue command to support flags X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, lukasz.czapnik@intel.com, leszek.pepiak@intel.com, anthony.l.nguyen@intel.com, Simon Horman , przemyslaw.kitszel@intel.com, jacob.e.keller@intel.com, intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Dear Anil, Thank you for your patch. Am 24.05.24 um 15:51 schrieb Anil Samal: > Current driver implementation for Sideband Queue supports a > fixed flag (ICE_AQ_FLAG_RD). To retrieve FEC statistics from > firmware, Sideband Queue command is used with a different flag. > > Extend API for Sideband Queue command to use 'flags' as input > argument. Please use `git format-patch`, and not `git show` to send patches. At least that is what I assume the unwanted indentation comes from. […] Kind regards, Paul