Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	<intel-wired-lan@lists.osuosl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix receive buffer size miscalculation
Date: Thu, 10 Aug 2023 16:44:58 -0700	[thread overview]
Message-ID: <e09cddf6-3207-b913-ad51-e283b3ebefa7@intel.com> (raw)
In-Reply-To: <16c05f6d-e971-b487-6eb8-ba5e2bcd658e@intel.com>

On 8/10/2023 2:33 PM, Tony Nguyen wrote:
> 
> 
> On 8/9/2023 5:23 PM, Jesse Brandeburg wrote:
>> The driver is misconfiguring the hardware for some values of MTU such
>> that
>> it could use multiple descriptors to receive a packet when it could have
>> simply used one.
>>
>> Change the driver to use a round-up instead of the result of a shift, as
>> the shift can truncate the lower bits of the size, and result in the
>> problem noted above. It also aligns this driver with similar code in
>> i40e.
>>
>> The insidiousness of this problem is that everything works with the wrong
>> size, it's just not working as well as it could, as some MTU sizes end up
>> using two or more descriptors, and there is no way to tell that is
>> happening without looking at ice_trace or a bus analyzer.
> 
> This should have a Fixes: ?

Dang, you're correct. I'll send a v2.

Thanks,
Jesse

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

      reply	other threads:[~2023-08-10 23:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10  0:23 [Intel-wired-lan] [PATCH iwl-net v1] ice: fix receive buffer size miscalculation Jesse Brandeburg
2023-08-10 11:02 ` Przemek Kitszel
2023-08-10 21:33 ` Tony Nguyen
2023-08-10 23:44   ` Jesse Brandeburg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e09cddf6-3207-b913-ad51-e283b3ebefa7@intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox