Re: [Intel-wired-lan] [PATCH net v3 1/4] iavf: Wait for reset in callbacks which trigger it

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 4/19/2023 4:50 AM, Kamil Maziarz wrote:
> From: Marcin Szycik <marcin.szycik@linux.intel.com>
> 
> There was a fail when trying to add the interface to bonding
> right after changing the MTU on the interface. It was caused
> by bonding interface unable to open the interface due to
> interface being in __RESETTING state because of MTU change.
> 
> Add new reset_waitqueue to indicate that reset has finished.
> Add waiting for reset to finish in .
> 
> Add waiting for reset to finish in callbacks which trigger hw reset:
> iavf_set_priv_flags(), iavf_change_mtu() and iavf_set_ringparam().
> We choose 5 sec for the timeout waiting time because the same interval
> is used in oot where waiting
> 
> Add a function iavf_wait_for_reset() to reuse waiting for reset code and
> use it also in iavf_set_channels(), which already waits for reset.
> We don't use error handling in iavf_set_channels() as this could
> cause the device to be in incorrect state if the reset was scheduled
> but hit timeout or the waitng function was interrupted by a signal.
> 
> We use a 5000ms timeout period because on Hyper-V based systems,
> this operation takes around 3000-4000ms. In normal circumstances,
> it doesn't take more than 500ms to complete.
> 
> Fixes: aa626da947e9 ("iavf: Detach device during reset task")
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Co-developed-by: Dawid Wesierski <dawidx.wesierski@intel.com>

The sign-off directly following co-developed needs to be the same.

WARNING: Co-developed-by and Signed-off-by: name/email do not match

> Signed-off-by: Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
> Signed-off-by: Dawid Wesierski <dawidx.wesierski@intel.com>
> Signed-off-by: Kamil Maziarz <kamil.maziarz@intel.com>

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan