From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EAACC7EE22 for ; Mon, 15 May 2023 15:07:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B608641D61; Mon, 15 May 2023 15:07:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B608641D61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1684163257; bh=P1cmhmDRHQ45wDoumCYynsGbhl/KQ4CGJv9KhQlrj2w=; h=From:Date:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Wrlay/Qd4bd5P1VpSoqx12kkpLO7DpcYDlKFNqIbbpL1SEdtfOt0W8xptYgrV/56i vbOTiwF7hpZCrZwDiVDrqkGFhcpdTRH3GXJsoJrGRFQUgGm0P/H7iAmG63E11gbDaU c3bxyMFsdFntz9QSZKqVKPVEusVcK8TS8eGT/Tp2Bg/DGijGbXk2JlBzZ+9Bq213Kg gfkBwuAGcdBMTiOlfoU/hakuplpaix8XbVJfaxilaGkVPBLWIQf7LWuT7YfZXbmBJC csnV3PT7R8V4B2HDXN9z9gCSiU+yOxhmUs34O9ZHe2JY8ghJ+3tq9a7nRmlo50x3hs V0GHJY9sLdvow== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v_aQPbjKXmzK; Mon, 15 May 2023 15:07:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 46C5941D41; Mon, 15 May 2023 15:07:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 46C5941D41 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 449F51BF573 for ; Mon, 15 May 2023 15:07:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1CECE41D41 for ; Mon, 15 May 2023 15:07:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1CECE41D41 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i1ejGvOzVAtZ for ; Mon, 15 May 2023 15:07:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7192641771 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7192641771 for ; Mon, 15 May 2023 15:07:33 +0000 (UTC) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-5DkrupHKMfiotz8FqbxaqA-1; Mon, 15 May 2023 11:07:23 -0400 X-MC-Unique: 5DkrupHKMfiotz8FqbxaqA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-96640336558so1237485366b.2 for ; Mon, 15 May 2023 08:07:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684163242; x=1686755242; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:cc:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jqAunJggVfMk8DVsWWYkCIQsfbXlahXMSDO8JBjiKzE=; b=ZgRa4T6hmhWGqJwlWC9fSE1oGF2R0LyKBbY+rbt9uTMLj+K3MutXKEzRi6Am1k+UP8 M3NykQUca9x7/z+NKSRNCzl/WOFP4XHPmSyOA+h910gOKz70oTXDLcHRmg5qgjmTqzZL 3eZ7GlsGxpZDsx6BoMrp/wzI9IDo/7Z9RhGwJgsUoFjg8QnZhb2m1Xyn4eBlPBydoPDR yZVOUbs3Py4nz3GW1+xrMsMNdIu9zMCOV+aJQfQty9kIvQP92Y3b1x2wYd30JutC4Wcj tA2KpLn47mCmjsRdRQbkZOLPcAr3PLPxb+HdVn7cFYaXMkNyFh6Hxvn5RXWyAyefU1vL GbUg== X-Gm-Message-State: AC+VfDzAMzqswVf0dZamgJanvCDDmPlQfMnBhCOdGOvmDVUFJA2H5RoE 6YSag53ZMa9Dz5Wtfjg/Tqz2i/zPwCiQqOJ+5NwFwIvVwO4X7J2TYcsZczk6EkhiIkhuqbPf2NV YuqDB6Aq+/uahYlJiqlR64Si/WQv7UA== X-Received: by 2002:a17:907:d91:b0:933:4d37:82b2 with SMTP id go17-20020a1709070d9100b009334d3782b2mr31485017ejc.57.1684163242598; Mon, 15 May 2023 08:07:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4KJfmiDaL9BJh3jJxYB1OG8NuTPCjYqSvJHsOpWGNg4A0jTsW7kReLmT9LoGqXUg8hKEYa+Q== X-Received: by 2002:a17:907:d91:b0:933:4d37:82b2 with SMTP id go17-20020a1709070d9100b009334d3782b2mr31484980ejc.57.1684163242248; Mon, 15 May 2023 08:07:22 -0700 (PDT) Received: from [192.168.41.200] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id l17-20020a170907915100b0095004c87676sm9682583ejs.199.2023.05.15.08.07.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 08:07:21 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Mon, 15 May 2023 17:07:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Larysa Zaremba , Stanislav Fomichev References: <20230512152607.992209-1-larysa.zaremba@intel.com> <20230512152607.992209-11-larysa.zaremba@intel.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684163252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jqAunJggVfMk8DVsWWYkCIQsfbXlahXMSDO8JBjiKzE=; b=DBICviUn80B4vACPChjXgYQ1fVN1D27i6m+AXsAn+MjifeJalm7tmA3rlvBossNCKHUJiM 4WLzTUQ0tojDuxPoE3ob0pJqM8S6NCXDILIBtqpaGTEShJaL1x8geE/pWpY1n7E2ySLFtQ XZn69KL0j/faaojoZvs/k12TRcn8wYU= X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DBICviUn Subject: Re: [Intel-wired-lan] [PATCH RESEND bpf-next 10/15] ice: Implement VLAN tag hint X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anatoly Burakov , Alexei Starovoitov , Andrii Nakryiko , Song Liu , Tony Nguyen , Maryam Tahhan , xdp-hints@xdp-project.net, Daniel Borkmann , John Fastabend , Jesse Brandeburg , intel-wired-lan@lists.osuosl.org, brouer@redhat.com, Yonghong Song , KP Singh , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Olsa , bpf@vger.kernel.org, Martin KaFai Lau Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 15/05/2023 15.41, Larysa Zaremba wrote: >>> + *vlan_tag = ice_get_vlan_tag_from_rx_desc(xdp_ext->eop_desc); >> Should we also do the following: >> >> if (!*vlan_tag) >> return -ENODATA; >> >> ? > Oh, returning VLAN tag with zero value really made sense to me at the beginning, > but after playing with different kinds of packets, I think returning error makes > more sense. Will change. > IIRC then VLAN tag zero is also a valid id, right? --Jesper _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan