From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF07AC001B0 for ; Mon, 7 Aug 2023 15:27:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6B72640B08; Mon, 7 Aug 2023 15:27:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6B72640B08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1691422069; bh=2ZoXzYvFiiYZXgGxlYbAtxBEc9yMo7plGq5k22BX2xU=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=s9n3dF+LqJrxre7W/OzpZQeDXCozlXUP4PaseQaa8G3znS2AVTzlc7FQKcxNbXn9L TR9kB7ef0FY2VYnxRZO8HusZfcue55nbdvipGxenPHX4c7RZNCVlx389nupXsCtqOh AJ+HcHsOqz4EeAKT7SECDl6wNvVMDPhEdbDoPjfjyo8crGnppvUoGEKPHvyVFYEEQe y5EmKClwOGVXu0vSY1JvANwk1FW1EoTNaRk2f2piEsh9oGabaSCR8qZwJmKFaS9Yzc GEI9yckfhaRubVy3+rLl2eJ+dNXMPiT9tqZbO2F0IklrG7gm0W3FCxBD0u3fh9uJA7 M2O91HITJn6CQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LyIUp_tt2Iz8; Mon, 7 Aug 2023 15:27:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 2D93040B69; Mon, 7 Aug 2023 15:27:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2D93040B69 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 02A921BF909 for ; Mon, 7 Aug 2023 05:00:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 176C08140D for ; Mon, 7 Aug 2023 05:00:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 176C08140D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C12pNSkQPjVi for ; Mon, 7 Aug 2023 05:00:43 +0000 (UTC) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by smtp1.osuosl.org (Postfix) with ESMTPS id 0025C80966 for ; Mon, 7 Aug 2023 05:00:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0025C80966 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RK3wY0dzpz1Z1Y9; Mon, 7 Aug 2023 12:57:49 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 13:00:35 +0800 Message-ID: Date: Mon, 7 Aug 2023 13:00:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Content-Language: en-US To: Ping-Ke Shih , "sgoutham@marvell.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "jesse.brandeburg@intel.com" , "anthony.l.nguyen@intel.com" , "tariqt@nvidia.com" , "s.shtylyov@omp.ru" , "aspriel@gmail.com" , "franky.lin@broadcom.com" , "hante.meuleman@broadcom.com" , "kvalo@kernel.org" , "richardcochran@gmail.com" , "yoshihiro.shimoda.uh@renesas.com" , "u.kleine-koenig@pengutronix.de" , "mkl@pengutronix.de" , "lee@kernel.org" , "set_pte_at@outlook.com" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list.pdl@broadcom.com" , "SHA-cyfmac-dev-list@infineon.com" References: <20230804035346.2879318-1-ruanjinjie@huawei.com> <20230804035346.2879318-7-ruanjinjie@huawei.com> From: Ruan Jinjie In-Reply-To: X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Mailman-Approved-At: Mon, 07 Aug 2023 15:27:25 +0000 Subject: Re: [Intel-wired-lan] [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2023/8/7 9:42, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Ruan Jinjie >> Sent: Friday, August 4, 2023 11:54 AM >> To: sgoutham@marvell.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >> jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; tariqt@nvidia.com; s.shtylyov@omp.ru; >> aspriel@gmail.com; franky.lin@broadcom.com; hante.meuleman@broadcom.com; kvalo@kernel.org; >> richardcochran@gmail.com; yoshihiro.shimoda.uh@renesas.com; ruanjinjie@huawei.com; >> u.kleine-koenig@pengutronix.de; mkl@pengutronix.de; lee@kernel.org; set_pte_at@outlook.com; >> linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; >> linux-rdma@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-wireless@vger.kernel.org; >> brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com >> Subject: [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator >> >> There is a ternary operator, the true or false judgement of which >> is unnecessary in C language semantics. >> >> Signed-off-by: Ruan Jinjie >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> index 8580a2754789..8328b22829c5 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> @@ -27351,8 +27351,7 @@ static int wlc_phy_cal_rxiq_nphy_rev3(struct brcms_phy *pi, >> >> for (rx_core = 0; rx_core < pi->pubpi.phy_corenum; rx_core++) { >> >> - skip_rxiqcal = >> - ((rxcore_state & (1 << rx_core)) == 0) ? true : false; >> + skip_rxiqcal = (rxcore_state & (1 << rx_core)) == 0; > > skip_rxiqcal = !(rxcore_state & (1 << rx_core)); Thank you! I'll improve it sooner. > >> >> wlc_phy_rxcal_physetup_nphy(pi, rx_core); >> >> -- >> 2.34.1 >> >> >> ------Please consider the environment before printing this e-mail. > _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan