From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E48EAC02198 for ; Fri, 14 Feb 2025 04:50:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6F9616F6A0; Fri, 14 Feb 2025 04:50:20 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id vfpbVrqZjf2R; Fri, 14 Feb 2025 04:50:19 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A3E3060B54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1739508619; bh=orTnkK40/j4ajEWBrPyqa344M+qGpD/Jz451eenCREo=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eCbNn4bqKZyrmwKninTyVUL63srv3KWACXrHUcALjG+SoErnttDOv93h1ng4XQxPg Tlb8WIJteq9Et86lgrkSFPAihCswiyKauIBWFKBtqGx2W5A7K9ZCB1+cLZsnaYkFxV JI85jwEST0b3ST9rq1dQut8MY6oZFzY2n4m7SGge77U4/CDXPXfDfRyEouTi0/sDdi 8vFoFb4eWr7BWwjcXKzaqO62vnl43sq9HgP4oWb2yLqbHStCIAcGN7MlshKNHCr/Sz 3OEWxb1dp6164gMpa8Se3nMc8hbOZ+UEWIfd0z39pXIW+reL4LTXXYdtlKIvasxy2x lKT8+beyEI3Cw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id A3E3060B54; Fri, 14 Feb 2025 04:50:19 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 2A8481C6 for ; Fri, 14 Feb 2025 04:50:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B015460BB8 for ; Fri, 14 Feb 2025 04:50:17 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8V-uXN6M717f for ; Fri, 14 Feb 2025 04:50:17 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.18; helo=mgamail.intel.com; envelope-from=faizal.abdul.rahim@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 89DEC60B13 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 89DEC60B13 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by smtp3.osuosl.org (Postfix) with ESMTPS id 89DEC60B13 for ; Fri, 14 Feb 2025 04:50:16 +0000 (UTC) X-CSE-ConnectionGUID: jVw0wmXDQM2Rx2j3e/Qmpg== X-CSE-MsgGUID: zNva/937RfiNsAvanfE8xg== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="40361828" X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="40361828" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2025 20:50:15 -0800 X-CSE-ConnectionGUID: 2b+fgtn9Q7+FDC4KwavSPQ== X-CSE-MsgGUID: wezvzmt3Tm6HcUS0QIfqlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,284,1732608000"; d="scan'208";a="113096903" Received: from mohdfai2-mobl.gar.corp.intel.com (HELO [10.247.123.6]) ([10.247.123.6]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2025 20:50:07 -0800 Message-ID: Date: Fri, 14 Feb 2025 12:50:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "Abdul Rahim, Faizal" To: Kurt Kanzenbach , Vladimir Oltean Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Furong Xu <0x1207@gmail.com>, Russell King , Serge Semin , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , Andrew Halaney , Choong Yong Liang , Kunihiko Hayashi , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org References: <20250210070207.2615418-1-faizal.abdul.rahim@linux.intel.com> <20250210070207.2615418-1-faizal.abdul.rahim@linux.intel.com> <20250212220121.ici3qll66pfoov62@skbuf> <87cyfmnjdh.fsf@kurt.kurt.home> <5902cc28-a649-4ae9-a5ba-83aa265abaf8@linux.intel.com> <20250213130003.nxt2ev47a6ppqzrq@skbuf> <1c981aa1-e796-4c53-9853-3eae517f2f6d@linux.intel.com> <877c5undbg.fsf@kurt.kurt.home> <20250213184613.cqc2zhj2wkaf5hn7@skbuf> <87v7td3bi1.fsf@kurt.kurt.home> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739508617; x=1771044617; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=gPVj4mO6xQJrCt3sZYWJNbH9C8SimtbKXR7wY1fjf90=; b=S3zgFCi9ie8IbTCTrmDoUn/IDnMpdrCgrXWP2QsQtrOfwTl7HaZtHURt Lam/vjKG4YyGpGT2UeLjC9Nk1ctVW5oVnt38bBoSvWApHpRzpdfWsijt4 xnvI3LyFujlPxGPvi7qoQE3BskIrck9OHMtflMOJYF4B4cGi6lU3vXgKT v4dKXQ/WyKkyfu/DLON4+cXJbnbHD/oM8mzsmAPgr0ZvdVPGE8DO32zlq mQYgFwacl70heqeNOpWmcje54v9uW5Gcat7iyxPAfnZL8uPlSL+9PvtpI ExkGK83W739qfQ/Fw2rLPSYEXML0AHie7xDFh8uBUau3bn9+BwaX+QjpH Q==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=S3zgFCi9 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/9] igc: Add support for Frame Preemption feature in IGC X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 14/2/2025 12:20 pm, Abdul Rahim, Faizal wrote: > > > On 14/2/2025 3:12 am, Kurt Kanzenbach wrote: >> On Thu Feb 13 2025, Vladimir Oltean wrote: >>> So, confusingly to me, it seems like one operating mode is fundamentally >>> different from the other, and something will have to change if both will >>> be made to behave the same. What will change? You say mqprio will behave >>> like taprio, but I think if anything, mqprio is the one which does the >>> right thing, in igc_tsn_tx_arb(), and taprio seems to use the default Tx >>> arbitration scheme? >> >> Correct. taprio is using the default scheme. mqprio configures it to >> what ever the user provided (in igc_tsn_tx_arb()). >> >>> I don't think I'm on the same page as you guys, because to me, it is >>> just odd that the P traffic classes would be the first ones with >>> mqprio, but the last ones with taprio. >> >> I think we are on the same page here. At the end both have to behave the >> same. Either by using igc_tsn_tx_arb() for taprio too or only using the >> default scheme for both (and thereby keeping broken_mqprio). Whatever >> Faizal implements I'll match the behavior with mqprio. >> > > Hi Kurt & Vladimir, > > After reading Vladimir's reply on tc, hw queue, and socket priority mapping > for both taprio and mqprio, I agree they should follow the same priority > scheme for consistency—both in code and command usage (i.e., taprio, > mqprio, and fpe in both configurations). Since igc_tsn_tx_arb() ensures a > standard mapping of tc, socket priority, and hardware queue priority, I'll > enable taprio to use igc_tsn_tx_arb() in a separate patch submission. > > I'll split the changes based on Vladimir's suggestion. > > First part - ethtool-mm related: > igc: Add support to get frame preemption statistics via ethtool > igc: Add support to get MAC Merge data via ethtool > igc: Add support to set tx-min-frag-size > igc: Add support for frame preemption verification > igc: Set the RX packet buffer size for TSN mode > igc: Optimize TX packet buffer utilization > igc: Rename xdp_get_tx_ring() for non-XDP usage > net: ethtool: mm: Extract stmmac verification logic into a common library > > Second part: > igc: Add support for preemptible traffic class in taprio and mqprio > igc: Use igc_tsn_tx_arb() for taprio queue priority scheme > igc: Kurt's patch on mqprio to use normal TSN Tx mode > > Kurt can keep igc_tsn_tx_arb() for his mqprio patch, so preemptible tc > should work the same for both taprio and mqprio. > > I'm suggesting to include Kurt's patch in the second part since there's > some dependency and potential code conflict, even though it mixes different > functional changes in the same series. I forgot that the second part patch: igc: Add support for preemptible traffic class in taprio and mqprio depends on the first part ethtool-mm, which would delay Kurt's patch. So Kurt, if you'd prefer to submit yours first, that's okay too.